Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react-scripts 3.3+ needs configuration changes #2

Open
sschmidTU opened this issue Apr 16, 2020 · 1 comment
Open

react-scripts 3.3+ needs configuration changes #2

sschmidTU opened this issue Apr 16, 2020 · 1 comment

Comments

@sschmidTU
Copy link
Contributor

sschmidTU commented Apr 16, 2020 •
edited
Loading

updating to react-scripts 3.3x (e.g. react-scripts 3.4.1) needs a change in configuration,
because process.env.PUBLIC_URL is used differently, see here:
facebook/create-react-app#8490 (comment)
(see 3 comments further down as well)

Note that this osmd react example project was created with an older version of create-react-app.
@sschmidTU
Copy link
Contributor Author

pinning to react-scripts 3.2.0 for now.

sschmidTU pushed a commit that referenced this issue Apr 16, 2020
chore: update and pin react-scripts to 3.2.0 (#2)
b43273f 
3.3.x needs configuration changes because of how it uses process.env.PUBLIC_URL,
see
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sschmidTU