Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO ISSUE: Folder name typo #2359

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Conversation

jgyselov
Copy link
Collaborator

I think this folder was meant to be called services not sevices, right?

@jgyselov jgyselov requested a review from a team as a code owner September 13, 2023 08:40
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 13, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 13, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, jgyselov, jkilzi

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 13, 2023

New changes are detected. LGTM label has been removed.

@jgyselov jgyselov force-pushed the folder_typo branch 2 times, most recently from 22d5727 to b0a6ff8 Compare September 14, 2023 07:05
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 14, 2023
@openshift-ci openshift-ci bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 14, 2023
@ammont82 ammont82 merged commit 6193c81 into openshift-assisted:master Sep 14, 2023
7 checks passed
rawagner pushed a commit to rawagner/facet-lib that referenced this pull request Sep 20, 2023
rawagner pushed a commit that referenced this pull request Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants