Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-15884: Simplify the code-style setup in the monorepo #2398

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

jkilzi
Copy link
Collaborator

@jkilzi jkilzi commented Oct 1, 2023

Most of the files under the libs/sdks folder are generated automatically (so the actual number of files to review is less than a hundred 😉 )

@jkilzi jkilzi requested a review from a team as a code owner October 1, 2023 13:56
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 1, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 1, 2023

@jkilzi: This pull request references MGMT-15884 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 1, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 1, 2023

@jkilzi: This pull request references MGMT-15884 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 1, 2023

@jkilzi: This pull request references MGMT-15884 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

Most of the files under the libs/sdks folder are generated automatically (so the actual number of files to review is less than a hundred 😉 )

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jkilzi jkilzi added this to the v2.26 milestone Oct 1, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 2, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 2, 2023

@jkilzi: This pull request references MGMT-15884 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

Most of the files under the libs/sdks folder are generated automatically (so the actual number of files to review is less than a hundred 😉 )

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Oct 3, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, jgyselov, jkilzi

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 3, 2023

New changes are detected. LGTM label has been removed.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 3, 2023

@jkilzi: This pull request references MGMT-15884 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

Most of the files under the libs/sdks folder are generated automatically (so the actual number of files to review is less than a hundred 😉 )

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ammont82 ammont82 merged commit 4046340 into openshift-assisted:master Oct 5, 2023
7 checks passed
rawagner pushed a commit to rawagner/facet-lib that referenced this pull request Oct 6, 2023
…assisted#2398)

Co-authored-by: Montse Ortega <ammont82@users.noreply.github.com>
rawagner pushed a commit that referenced this pull request Oct 6, 2023
Co-authored-by: Montse Ortega <ammont82@users.noreply.github.com>
@jkilzi jkilzi deleted the tasks/MGMT-15884 branch October 11, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants