Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use full paths for react-icons and react-tokens #2447

Merged
merged 4 commits into from
Dec 11, 2023

Conversation

jschuler
Copy link
Contributor

@jschuler jschuler commented Dec 5, 2023

Cuts down OCM bundle by quite a bit

Should be done going forward!
i.e
No:

import { global_palette_green_500 as okColor } from '@patternfly/react-tokens';
import { ExclamationCircleIcon } from '@patternfly/react-icons';

Yes:

import { global_palette_green_500 as okColor } from '@patternfly/react-tokens/dist/js/global_palette_green_500';
import { ExclamationCircleIcon } from '@patternfly/react-icons/dist/js/icons/exclamation-circle-icon';

Before:
Screenshot 2023-12-05 at 10 05 39 AM

After:
Screenshot 2023-12-05 at 10 42 35 AM

@jschuler jschuler requested a review from a team as a code owner December 5, 2023 15:45
Copy link

openshift-ci bot commented Dec 5, 2023

Welcome @jschuler! It looks like this is your first PR to openshift-assisted/assisted-installer-ui 🎉

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 5, 2023
Copy link
Contributor

@celdrake celdrake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to see the bundle size coming down, thanks a lot!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2023
Copy link

openshift-ci bot commented Dec 6, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: celdrake, jkilzi, jschuler

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2023
Copy link

openshift-ci bot commented Dec 11, 2023

New changes are detected. LGTM label has been removed.

@ammont82 ammont82 merged commit d310ad0 into openshift-assisted:master Dec 11, 2023
7 checks passed
@celdrake celdrake added this to the v2.29 milestone Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants