-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NO-ISSUE: Adapting code for decoupling tasks #2592
NO-ISSUE: Adapting code for decoupling tasks #2592
Conversation
@ammont82: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im not sure this is the correct solution. The app is running within the Router, we should not be creating a new instances.
Isn't this caused by importing Link
component from react-router-dom
instead of react-router-dom-v5-compat
?
I tested it but not works. Running locally I saw this error "You should not use outside a ". Still working on it, trying to find a better solution |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ammont82, jgyselov, rawagner The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
Testing decoupling inside uhc-portal I found these errors:
It seems a problem with component.
I've changed the way is used inside ClusterBreadcrumbs and BackButton.