Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: Adapting code for decoupling tasks #2592

Conversation

ammont82
Copy link
Contributor

@ammont82 ammont82 commented May 31, 2024

Testing decoupling inside uhc-portal I found these errors:
image

It seems a problem with component.
I've changed the way is used inside ClusterBreadcrumbs and BackButton.

@ammont82 ammont82 requested a review from a team as a code owner May 31, 2024 12:32
@openshift-ci-robot
Copy link

@ammont82: This pull request explicitly references no jira issue.

In response to this:

Testing decoupling inside uhc-portal I found these errors:
image

It seems a problem with component.
I've changed the way is used inside BreadCrumbs and BackButton.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 31, 2024
@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 31, 2024
jgyselov
jgyselov previously approved these changes Jun 3, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2024
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 5, 2024
@ammont82 ammont82 requested a review from jgyselov June 5, 2024 09:41
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2024
Copy link
Contributor

@rawagner rawagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im not sure this is the correct solution. The app is running within the Router, we should not be creating a new instances.

Isn't this caused by importing Link component from react-router-dom instead of react-router-dom-v5-compat ?

@ammont82
Copy link
Contributor Author

ammont82 commented Jun 6, 2024

Link component from react-router-dom instead of react-router-dom-v5-compat ?

I tested it but not works. Running locally I saw this error "You should not use outside a ". Still working on it, trying to find a better solution

Copy link

openshift-ci bot commented Jul 11, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, jgyselov, rawagner

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2024
Copy link

openshift-ci bot commented Jul 12, 2024

New changes are detected. LGTM label has been removed.

@ammont82 ammont82 merged commit 7267cff into openshift-assisted:master Jul 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants