Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-18050: UI warning icon not changed to error icon on 24 hours timeout in hosts table #2596

Conversation

ammont82
Copy link
Contributor

@ammont82 ammont82 commented Jun 7, 2024

Related to https://issues.redhat.com/browse/MGMT-18050

When timeout occured during installation there is a yellow triangle for warnning
In case total timeout 24 hours , hosts ((all) changed to error RED.

Before changes:
image

After changes:
image

@ammont82 ammont82 added the OCM label Jun 7, 2024
@ammont82 ammont82 requested a review from a team as a code owner June 7, 2024 09:28
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 7, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 7, 2024

@ammont82: This pull request references MGMT-18050 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to this:

Related to https://issues.redhat.com/browse/MGMT-18050

When timeout occured during installation there is a yellow triangle for warnning
In case total timeout 24 hours , hosts ((all) changed to error RED.

Before changes:
image

After changes:
image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 7, 2024
@ammont82 ammont82 force-pushed the MGMT-18050-change-warning-icon-to-error-icon-after-24-hours branch from 16880a9 to 4f91856 Compare June 7, 2024 11:48
@ammont82 ammont82 requested a review from jgyselov June 7, 2024 11:48
@ammont82 ammont82 requested a review from celdrake June 10, 2024 14:13
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 11, 2024
Copy link

openshift-ci bot commented Jun 11, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, celdrake, jgyselov

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ammont82 ammont82 merged commit f58c142 into openshift-assisted:master Jun 11, 2024
7 checks passed
ammont82 added a commit to ammont82/assisted-installer-ui that referenced this pull request Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. OCM size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants