Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-17123: Add CPU and RAM requirements for MCE operator #2599

Conversation

ammont82
Copy link
Contributor

@ammont82 ammont82 commented Jun 12, 2024

Related to https://issues.redhat.com/browse/MGMT-17123

Read the CPU and RAM requirements from additional requirements API.

image

@ammont82 ammont82 requested a review from a team as a code owner June 12, 2024 09:40
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 12, 2024

@ammont82: This pull request references MGMT-17123 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to this:

Related to https://issues.redhat.com/browse/MGMT-17123

Read the CPU and RAM requirements from additional requirements API.

Captura desde 2024-06-12 11-39-25

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 12, 2024
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 12, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 12, 2024

@ammont82: This pull request references MGMT-17123 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to this:

Related to https://issues.redhat.com/browse/MGMT-17123

Read the CPU and RAM requirements from additional requirements API.

image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jgyselov
jgyselov previously approved these changes Jun 12, 2024
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Jun 12, 2024
@ammont82 ammont82 force-pushed the MGMT-17123-no-ram-and-cpu-requirements-for-mce-operator branch from 1e89b84 to 432da38 Compare June 12, 2024 12:22
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 12, 2024

@ammont82: This pull request references MGMT-17123 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to this:

Related to https://issues.redhat.com/browse/MGMT-17123

Read the CPU and RAM requirements from additional requirements API.

image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2024
Copy link

openshift-ci bot commented Jun 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, celdrake, jgyselov

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ammont82 ammont82 merged commit 63cb66a into openshift-assisted:master Jun 12, 2024
7 checks passed
ammont82 added a commit to ammont82/assisted-installer-ui that referenced this pull request Jun 12, 2024
ammont82 added a commit that referenced this pull request Jun 12, 2024
)

* Add CPU and RAM requirements for MCE operator

* mend
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants