Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-18241: Review docs_links file to align all the URLs with correct links #2617

Conversation

ammont82
Copy link
Contributor

@ammont82 ammont82 requested a review from a team as a code owner June 26, 2024 05:47
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 26, 2024

@ammont82: This pull request references MGMT-18241 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to this:

Related to https://issues.redhat.com/browse/MGMT-18241

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 26, 2024
@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 26, 2024
@ammont82 ammont82 changed the title MGMT-18241: Review AI docs_links file to align all the URLs with correct links MGMT-18241: Review docs_links file to align all the URLs with correct links Jun 26, 2024
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 26, 2024
@ammont82 ammont82 force-pushed the MGMT-18241-review-ai-docs-links-file branch from 0568bfe to 5c90742 Compare June 26, 2024 06:11
jgyselov
jgyselov previously approved these changes Jun 26, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2024
@ammont82 ammont82 force-pushed the MGMT-18241-review-ai-docs-links-file branch from 1522a5d to 694a639 Compare June 26, 2024 09:31
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 27, 2024
Copy link

openshift-ci bot commented Jun 27, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, celdrake, jgyselov

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ammont82 ammont82 merged commit db80182 into openshift-assisted:master Jun 27, 2024
7 checks passed
ammont82 added a commit to ammont82/assisted-installer-ui that referenced this pull request Jun 27, 2024
… links (openshift-assisted#2617)

* DOC URL contains hard-coded number

* Replace docs.openshift.com by docs.redhat.com

* Changes in approving certificate-signing requests link

* Changes in MCE link resource requirements

* Changing MCE docs link

* Reviewing all docs links

* Add DEFAULT_OPENSHIFT_DOCS_VERSION constant to docs_links file

* Change links for Nutanix and vSphere docs and adding OCI docs link

* Adjusting links for operators
ammont82 added a commit that referenced this pull request Jun 27, 2024
… links (#2617) (#2622)

* DOC URL contains hard-coded number

* Replace docs.openshift.com by docs.redhat.com

* Changes in approving certificate-signing requests link

* Changes in MCE link resource requirements

* Changing MCE docs link

* Reviewing all docs links

* Add DEFAULT_OPENSHIFT_DOCS_VERSION constant to docs_links file

* Change links for Nutanix and vSphere docs and adding OCI docs link

* Adjusting links for operators
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants