Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-17388: Log string literal format shown with "special" characters #2626

Merged

Conversation

jgyselov
Copy link
Collaborator

https://issues.redhat.com/browse/MGMT-17388

image

Replacing \n with a space is probably the best we can do here.

@jgyselov jgyselov requested a review from a team as a code owner June 28, 2024 11:23
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 28, 2024

@jgyselov: This pull request references MGMT-17388 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to this:

https://issues.redhat.com/browse/MGMT-17388

image

Replacing \n with a space is probably the best we can do here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 28, 2024
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 28, 2024
@ammont82 ammont82 added this to the v2.33 milestone Jul 1, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2024
Copy link
Contributor

@celdrake celdrake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you consider splitting the message in the new line and creating a div / li per item?

Copy link

openshift-ci bot commented Jul 4, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, celdrake, jgyselov

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jgyselov
Copy link
Collaborator Author

jgyselov commented Jul 4, 2024

Did you consider splitting the message in the new line and creating a div / li per item?

I did consider it. But given how rare \n appearing seems to be (I've only seen this one instance in this screenshot), I don't think it's worth it.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 4, 2024
Copy link

openshift-ci bot commented Jul 4, 2024

New changes are detected. LGTM label has been removed.

@ammont82 ammont82 merged commit bd6dd4f into openshift-assisted:master Jul 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants