-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MGMT-18357: Change alignment of MacIpMapping fields in Static Network Configuration #2633
MGMT-18357: Change alignment of MacIpMapping fields in Static Network Configuration #2633
Conversation
@ammont82: This pull request references MGMT-18357 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@ammont82: This pull request references MGMT-18357 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
...ui-lib/lib/ocm/components/clusterConfiguration/staticIp/components/YamlView/MacIpMapping.tsx
Show resolved
Hide resolved
91d14b8
to
204a734
Compare
@ammont82: This pull request references MGMT-18357 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
204a734
to
98805ab
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ammont82, celdrake, jgyselov The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
Related to https://issues.redhat.com/browse/MGMT-18357
If we create a cluster with Static IP configuration and try to map different Map interfaces the fields don't look aligned.
Before changes:
After changes: