Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-18357: Change alignment of MacIpMapping fields in Static Network Configuration #2633

Conversation

ammont82
Copy link
Contributor

@ammont82 ammont82 commented Jul 9, 2024

Related to https://issues.redhat.com/browse/MGMT-18357

If we create a cluster with Static IP configuration and try to map different Map interfaces the fields don't look aligned.

Before changes:

image

After changes:
image

@ammont82 ammont82 added the OCM label Jul 9, 2024
@ammont82 ammont82 added this to the v2.33 milestone Jul 9, 2024
@ammont82 ammont82 requested a review from a team as a code owner July 9, 2024 09:05
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 9, 2024

@ammont82: This pull request references MGMT-18357 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to this:

Related to https://issues.redhat.com/browse/MGMT-18357

If we create a cluster with Static IP configuration and try to map different Map interfaces the fields don't look aligned.

Before changes:

image

After changes:
image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 9, 2024
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 9, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 9, 2024

@ammont82: This pull request references MGMT-18357 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to this:

Related to https://issues.redhat.com/browse/MGMT-18357

If we create a cluster with Static IP configuration and try to map different Map interfaces the fields don't look aligned.

Before changes:

image

After changes:
image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2024
celdrake
celdrake previously approved these changes Jul 9, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2024
@ammont82 ammont82 force-pushed the MGMT-18357-static-network-mac-interfaces-mapping-fields branch from 91d14b8 to 204a734 Compare July 9, 2024 13:17
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 9, 2024

@ammont82: This pull request references MGMT-18357 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to this:

Related to https://issues.redhat.com/browse/MGMT-18357

If we create a cluster with Static IP configuration and try to map different Map interfaces the fields don't look aligned.

Before changes:

image

After changes:
image

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ammont82 ammont82 force-pushed the MGMT-18357-static-network-mac-interfaces-mapping-fields branch from 204a734 to 98805ab Compare July 10, 2024 09:42
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 10, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2024
Copy link

openshift-ci bot commented Jul 10, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, celdrake, jgyselov

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2024
Copy link

openshift-ci bot commented Jul 10, 2024

New changes are detected. LGTM label has been removed.

@ammont82 ammont82 merged commit ed3200b into openshift-assisted:master Jul 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. OCM size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants