Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-18358: Clear alerts when change from one view to another in Static network configurations step #2634

Conversation

ammont82
Copy link
Contributor

@ammont82 ammont82 commented Jul 9, 2024

Related with https://issues.redhat.com/browse/MGMT-18358

In "Static Network Configurations" page, in Yaml view if you add invalid YAML and some mac interface mapping and change to Form view the error alert don't dissapears

clear_alerts_changing_static_network_views.mp4

@ammont82 ammont82 added the OCM label Jul 9, 2024
@ammont82 ammont82 added this to the v2.33 milestone Jul 9, 2024
@ammont82 ammont82 requested a review from a team as a code owner July 9, 2024 10:45
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 9, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 9, 2024

@ammont82: This pull request references MGMT-18358 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to this:

Related with https://issues.redhat.com/browse/MGMT-18358

In "Static Network Configurations" page, in Yaml view if you add invalid YAML and some mac interface mapping and change to Form view the error alert don't dissapears

clear_alerts_changing_static_network_views.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 9, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 9, 2024

@ammont82: This pull request references MGMT-18358 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to this:

Related with https://issues.redhat.com/browse/MGMT-18358

In "Static Network Configurations" page, in Yaml view if you add invalid YAML and some mac interface mapping and change to Form view the error alert don't dissapears

clear_alerts_changing_static_network_views.mp4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2024
Copy link

openshift-ci bot commented Jul 9, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, celdrake, jgyselov

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ammont82 ammont82 merged commit 85e4a93 into openshift-assisted:master Jul 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. OCM size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants