Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-17147: Update openshift-assisted/ui-lib to react-router-dom v6 #2637

Merged
merged 6 commits into from
Aug 2, 2024

Conversation

jgyselov
Copy link
Collaborator

@jgyselov jgyselov commented Jul 11, 2024

@jgyselov jgyselov requested a review from a team as a code owner July 11, 2024 13:14
@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 11, 2024
@jgyselov jgyselov changed the title Update openshift-assisted/ui-lib to react-router-dom v6 MGMT-17147: Update openshift-assisted/ui-lib to react-router-dom v6 Jul 11, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 11, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 11, 2024

@jgyselov: This pull request references MGMT-17147 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.17.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 11, 2024

@jgyselov: This pull request references MGMT-17147 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.17.0" version, but no target version was set.

In response to this:

https://issues.redhat.com/browse/MGMT-17147

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jgyselov jgyselov force-pushed the upgrade_react_router_2 branch 2 times, most recently from 5019a59 to dadbded Compare July 12, 2024 08:18
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 13, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 1, 2024

@jgyselov: This pull request references MGMT-17147 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.17.0" version, but no target version was set.

In response to this:

https://issues.redhat.com/browse/MGMT-17147

UHC-Portal PR: https://gitlab.cee.redhat.com/service/uhc-portal/-/merge_requests/5815

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 1, 2024
ammont82
ammont82 previously approved these changes Aug 1, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 1, 2024
@jgyselov jgyselov added this to the v2.34 milestone Aug 1, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 2, 2024
Copy link

openshift-ci bot commented Aug 2, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, jgyselov, rawagner

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jgyselov jgyselov merged commit 8546719 into openshift-assisted:master Aug 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants