Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MGMT-17540: Remove unnecessary calls to openshift-versions API in cluster creation page [FOLLOWUP] #2638

Merged
merged 2 commits into from
Jul 12, 2024
Merged

MGMT-17540: Remove unnecessary calls to openshift-versions API in cluster creation page [FOLLOWUP] #2638

merged 2 commits into from
Jul 12, 2024

Conversation

jgyselov
Copy link
Collaborator

https://issues.redhat.com/browse/MGMT-17540

I missed a couple components.

@jgyselov jgyselov requested a review from a team as a code owner July 12, 2024 10:55
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 12, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 12, 2024 •
edited by openshift-ci bot

@jgyselov: This pull request references MGMT-17540 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to this:

https://issues.redhat.com/browse/MGMT-17540

I missed a couple components.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 12, 2024
@jgyselov jgyselov mentioned this pull request Jul 12, 2024
Merged
ammont82
ammont82 previously approved these changes Jul 12, 2024
View reviewed changes
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jul 12, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ammont82, jgyselov

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ammont82 ammont82 merged commit 6402f88 into openshift-assisted:master Jul 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ammont82 ammont82 ammont82 approved these changes

Assignees

@ammont82 ammont82

Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jgyselov @openshift-ci-robot @ammont82