Skip to content
This repository has been archived by the owner on Jun 7, 2021. It is now read-only.

Knative Event wiring #12

Merged
merged 2 commits into from
Aug 22, 2019
Merged

Knative Event wiring #12

merged 2 commits into from
Aug 22, 2019

Conversation

zroubalik
Copy link
Contributor

  • creates Knative Eventing Channel and Subscription if user specifies Events: true in CRD

@zroubalik zroubalik requested a review from lance August 21, 2019 13:56
@zroubalik
Copy link
Contributor Author

this is the first step, necessary changes on runtime image will follow soon

lance
lance reviewed Aug 21, 2019
View reviewed changes
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/apis/faas/v1alpha1/jsfunction_types.go
@@ -11,7 +11,8 @@ import (
// +k8s:openapi-gen=true
type JSFunctionSpec struct {
Func string `json:"func"`
Package string `json:"package"`
Package string `json:"package,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this as part of the PR :)

pkg/controller/jsfunction/jsfunction_controller.go
Name: fmt.Sprintf("nodejs-%s", functionName),
Ports: []corev1.ContainerPort{{
ContainerPort: 8181,
ContainerPort: 8080,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rhuss originally changed this from 8080 to 8181. I subsequently ran into problems using 8080, but can't recall which it was of the many problems I have run into lately. :) Not sure what it should really be.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8181 didn't worked for me, it was listening on 8080

@lance lance mentioned this pull request Aug 21, 2019
Open
@zroubalik zroubalik merged commit f01e94a into openshift-cloud-functions:master Aug 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lance lance lance left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zroubalik @lance