This repository has been archived by the owner on Jun 7, 2021. It is now read-only.
First test e2e #19
Merged
First test e2e #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lance
reviewed
Sep 4, 2019
|
Please squash your commits into one. |
|
I'm not sure it can run in our pipeline, since we need an openshift cluster to connect to. Honestly I don't know |
wrt CI/CD - We might want to integrate with OpenShift CI used by Knative projects. It creates real cluster and run the tests on it. Might be exaggerated ATM. I've created an issue for this: #21 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17
Created first e2e with basic support functions. It should be a good starting point for next e2e