-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable service catalog and tsb by default in CI #718
Conversation
@stevekuznetsov ptal |
This will not impact GCE, but should be sufficient to globally install the TSB on all Origin installs. Is this heavyweight and/or does it take time? If so, you may want to add it to only the Origin conformance e2e job (or whatever jobs are running your tests) so you don't burden e.g. the Installer tests with it. |
92d08be
to
f4e5c89
Compare
@stevekuznetsov thanks for the feedback, how about this? |
f4e5c89
to
1c91812
Compare
1c91812
to
a8c19ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pending comment from clayton lgtm
@@ -121,7 +121,7 @@ extensions: | |||
docker pull openshift/origin-gce:latest | |||
fi | |||
|
|||
../../bin/local.sh ansible-playbook -e "provision_gce_docker_storage_driver=${DOCKER_STORAGE_DRIVER}" -e "openshift_test_repo=${location_url}" playbooks/launch.yaml | |||
../../bin/local.sh ansible-playbook -e "provision_gce_docker_storage_driver=${DOCKER_STORAGE_DRIVER}" -e "openshift_test_repo=${location_url}" -e "openshift_enable_service_catalog=true" -e "template_service_broker_install=true" playbooks/launch.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smarterclayton PTAL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong place, add it to openshift/release cluster/test-deploy/data/vars.yaml
a8c19ea
to
909b5be
Compare
@stevekuznetsov repushed, removed gce-specific bits, ptal |
/lgtm |
This broke install_update completely (since 8:30am on Friday).
I'm inclined to revert to fix. |
No description provided.