move yaml lib into artcommon lib #1162
Conversation
artcommon/artcommonlib/util.py
Outdated
| @@ -34,6 +34,15 @@ def remove_suffix(s: str, suffix: str) -> str: | |||
| return s[:] | |||
|
|
|||
|
|
|||
| def yaml_handler(): | |||
There was a problem hiding this comment.
This function needs more describable name, like new_roundtrip_yaml_processor
artcommon/artcommonlib/util.py
Outdated
| @@ -34,6 +34,15 @@ def remove_suffix(s: str, suffix: str) -> str: | |||
| return s[:] | |||
|
|
|||
|
|
|||
| def yaml_handler(): | |||
There was a problem hiding this comment.
This function needs more describable name, like new_roundtrip_yaml_processor
Ximinhan
added
the
tide/merge-method-squash
|
@Ximinhan: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vfreex The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-bot
bot
merged commit 679a335
into
openshift-eng:main
Add yaml_handler function to artcommon lib to set yaml config and load by others to reduce duplication
also set indent config for yaml, this will change list item
to
for better reading