Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ART-11251: [4.19][konflux] update vendor to RedHat, Inc. #5667

Merged

Conversation

ashwindasr
Copy link
Contributor

@ashwindasr ashwindasr commented Nov 13, 2024

Fixes

 - metadata:
      code: labels.required_labels
    msg: 'The "vendor" label has an unexpected "Red Hat" value. Must be one of: Red
      Hat, Inc.' - metadata:
      code: labels.required_labels
    msg: 'The "vendor" label has an unexpected "Red Hat" value. Must be one of: Red
      Hat, Inc.'

As Joep commented here, since the label is coming from the ELS image, we don't need to override the value, which was already correct

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 13, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 13, 2024

@ashwindasr: This pull request references ART-11251 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Fixes

- metadata:
     code: labels.required_labels
   msg: 'The "vendor" label has an unexpected "Red Hat" value. Must be one of: Red
     Hat, Inc.' - metadata:
     code: labels.required_labels
   msg: 'The "vendor" label has an unexpected "Red Hat" value. Must be one of: Red
     Hat, Inc.'

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ashwindasr ashwindasr added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2024
@ashwindasr ashwindasr changed the title ART-11251: [konflux] update vendor to RedHat, Inc. ART-11251: [4.19][konflux] update vendor to RedHat, Inc. Nov 13, 2024
@ashwindasr
Copy link
Contributor Author

/unhold

Tested, EC error was resolved.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2024
@ashwindasr ashwindasr added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 13, 2024
@ashwindasr ashwindasr closed this Nov 13, 2024
@ashwindasr ashwindasr reopened this Nov 13, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 13, 2024

@ashwindasr: This pull request references ART-11251 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Fixes

- metadata:
     code: labels.required_labels
   msg: 'The "vendor" label has an unexpected "Red Hat" value. Must be one of: Red
     Hat, Inc.' - metadata:
     code: labels.required_labels
   msg: 'The "vendor" label has an unexpected "Red Hat" value. Must be one of: Red
     Hat, Inc.'

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Nov 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from ashwindasr. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
Copy link
Contributor

openshift-ci bot commented Nov 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from ashwindasr. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@joepvd
Copy link
Contributor

joepvd commented Nov 13, 2024

Think the vendor label is coming from the els image. Let's not override it if we can. Meaning, let's drop this config rather than correct it :)

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 13, 2024

@ashwindasr: This pull request references ART-11251 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Fixes

- metadata:
     code: labels.required_labels
   msg: 'The "vendor" label has an unexpected "Red Hat" value. Must be one of: Red
     Hat, Inc.' - metadata:
     code: labels.required_labels
   msg: 'The "vendor" label has an unexpected "Red Hat" value. Must be one of: Red
     Hat, Inc.'

As Joep commented here, since the label is coming from the ELS image, we don't need to override the value, which was already correct

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@joepvd
Copy link
Contributor

joepvd commented Nov 13, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2024
@ashwindasr ashwindasr added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 13, 2024
@ashwindasr
Copy link
Contributor Author

Tested worked

@ashwindasr ashwindasr merged commit 89ff1c0 into openshift-eng:openshift-4.19 Nov 13, 2024
1 of 2 checks passed
@ashwindasr ashwindasr deleted the update-vendor-4.19 branch November 13, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants