Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

images/cluster-version-operator: Use Dockerfile.rhel #634

Merged

Conversation

wking
Copy link

@wking wking commented Aug 29, 2020

Because we don't care if it's 7 or 8. Catches up with openshift/cluster-version-operator@32204c00ba (openshift/cluster-version-operator#444).

Not sure if this needs to land in openshift-4.6-rhel-8 too or not.

@openshift-bot
Copy link

Build #1

Validating images/cluster-version-operator.yml

@wking wking changed the base branch from openshift-4.6 to openshift-4.6-rhel-8 August 31, 2020 20:15
Because we don't care if it's 7 or 8.  Catches up with
openshift/cluster-version-operator@32204c00ba (Dockerfile.rhel: Use a
RHEL-version-agnostic filename, 2020-08-25,
openshift/cluster-version-operator#444).
@wking wking force-pushed the cvo-rhel-agnostic branch from 3f1b8fe to 17f6526 Compare August 31, 2020 20:16
@wking
Copy link
Author

wking commented Aug 31, 2020

Rebased onto openshift-4.6-rhel-8, which @yselkowitz suggests is the preferred target branch for this.

@openshift-bot
Copy link

Build #2

Validating images/cluster-version-operator.yml

@openshift-bot
Copy link

Build #3

Validating images/cluster-version-operator.yml

@yselkowitz
Copy link

/lgtm
/assign @jupierce

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2020
Copy link
Contributor

@thiagoalessio thiagoalessio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@thiagoalessio thiagoalessio merged commit 3fe18d2 into openshift-eng:openshift-4.6-rhel-8 Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants