Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--http-proxy, --https-proxy, --no-proxy doesn't really do anything #82

Open
michalkutyla opened this issue Nov 3, 2017 · 2 comments
Open

Comments

@michalkutyla
Copy link

michalkutyla commented Nov 3, 2017

Hi,
nice project Jorg!

Maybe I'm missing something but it looks like proxy parameters are parsed and then ignored. I patched it on my machine by adding

if [ ! -z $__PARM_OC_HTTP_PROXY ]; then
CMDLINE+=" --http-proxy=$__PARM_OC_HTTP_PROXY"
fi
if [ ! -z $__PARM_OC_HTTPS_PROXY ]; then
CMDLINE+=" --https-proxy=$__PARM_OC_HTTPS_PROXY"
fi
if [ ! -z $__PARM_OC_NO_PROXY ]; then
CMDLINE+=" --no-proxy=$__PARM_OC_NO_PROXY"
fi

If you like it, I will submit a pull request.

Cheers,
Michal

@jorgemoralespou
Copy link
Contributor

Please do. I introduce these commands before the feature was available on oc cluster up, and nobody reminded me about it, and I forgot, since I don't use a proxy.

michalkutyla added a commit to michalkutyla/oc-cluster-wrapper that referenced this issue Nov 5, 2017
@cmcconnell1
Copy link

Hello, and thanks for this project/tool. This is very useful.

For anyone else running into docker proxy issues (on MACOS/OSX), it appears as though recent versions (a few months ago) have added a proxy that cannot be disabled and this is causing workflows to break, etc.

Details, workarounds and related/open issues:
openshift/origin#18596

Thanks,
-cmcc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants