Fix profiles in bash command completion #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The completion function used a hard coded reference to $HOME of the user who originally executed the command. This meant that if the root user executed `oc-cluster completion bash` the profiles variable would be assigned to the base names in `/root/.oc/profiles/`. This change utilizes the environment variable OPENSHIFT_HOME_DIR and OPENSHIFT_PROFILES_DIR and if not set, assigns them in the same manner that oc-cluster itself does. This allows the completion script to work on a multi-user machine or when invoked by the root user for the purpose of writing the output to /etc/bash_completion.d/oc-cluster.bash.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The completion function used a hard coded reference to $HOME of the user
who originally executed the command. This meant that if the root user
executed
oc-cluster completion bashthe profiles variable would beassigned to the base names in
/root/.oc/profiles/.This change utilizes the environment variable OPENSHIFT_HOME_DIR and
OPENSHIFT_PROFILES_DIR and if not set, assigns them in the same manner
that oc-cluster itself does. This allows the completion script to work
on a multi-user machine or when invoked by the root user for the purpose
of writing the output to /etc/bash_completion.d/oc-cluster.bash.