Workaround openshift-tools-installer taking an extra 3 minutes per executions #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 17, 2024
This was referenced Jul 18, 2024
acornett21
approved these changes
Jul 18, 2024
|
/lgtm |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For whatever reason, the openshift-tools-installer action now takes 3 minutes in our workflow, and we call it ~3 times. On a bad day, that's causing the containing steps to take 4x their normal duration, which is in turn adding enough time to cause our nightly tests (and presumably full E2E) to fail with a 6 hour timeout.
I observed that enabling caching will speed this back up, but disabling the cache has been a conscious decision because of our reuse of the 0.1.0 tag in chart-verifier. That is, we delete and recreate the 0.1.0 as our development release, always reflecting main. By caching, we run the risk of not properly testing new chart-verifier changes as they happen because we may pull an old binary from the cache.
We'll see if that pans out, but for now, we need to release sometime in the near future to fix a bug. To that end...
This PR enables caching for the openshift-tools-installer execution throughout our workflow.
Reference: