Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v1.14] Prevent generation only updates (#3915) #1102

Conversation

pierDipi
Copy link
Member

* Prevent generation only contract updates

This guards contract ConfigMap updates when only `generation`
changes.

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Refactor to simplify and remove reconciler level change detection

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

---------

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@openshift-ci openshift-ci bot requested review from lberk and matzew May 31, 2024 13:35
@pierDipi
Copy link
Member Author

/cc @mgencur @maschmid @creydr

Copy link
Member

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented May 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierDipi
Copy link
Member Author

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD beba7b0 and 2 for PR HEAD a082da4 in total

@pierDipi
Copy link
Member Author

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 6544de7 and 1 for PR HEAD a082da4 in total

@openshift-merge-bot openshift-merge-bot bot merged commit 22b418b into openshift-knative:release-v1.14 Jun 5, 2024
7 checks passed
@pierDipi
Copy link
Member Author

pierDipi commented Jun 6, 2024

/cherry-pick release-1.12

@pierDipi
Copy link
Member Author

pierDipi commented Jun 6, 2024

/cherry-pick release-v1.12

@pierDipi pierDipi deleted the cp-483904b1ef984bdf792dbeba571fda04e5db0963-v1.14 branch June 6, 2024 13:56
@openshift-cherrypick-robot

@pierDipi: cannot checkout release-1.12: error checking out "release-1.12": exit status 1 error: pathspec 'release-1.12' did not match any file(s) known to git

In response to this:

/cherry-pick release-1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@pierDipi: #1102 failed to apply on top of branch "release-v1.12":

Applying: Prevent generation only updates (#3915)
Using index info to reconstruct a base tree...
M	control-plane/pkg/reconciler/broker/broker.go
M	control-plane/pkg/reconciler/channel/channel.go
M	control-plane/pkg/reconciler/channel/v2/channelv2.go
M	control-plane/pkg/reconciler/consumer/consumer.go
M	control-plane/pkg/reconciler/sink/kafka_sink.go
M	control-plane/pkg/reconciler/trigger/trigger.go
M	control-plane/pkg/reconciler/trigger/trigger_test.go
Falling back to patching base and 3-way merge...
Auto-merging control-plane/pkg/reconciler/trigger/trigger_test.go
Auto-merging control-plane/pkg/reconciler/trigger/trigger.go
Auto-merging control-plane/pkg/reconciler/sink/kafka_sink.go
Auto-merging control-plane/pkg/reconciler/consumer/consumer.go
Auto-merging control-plane/pkg/reconciler/channel/v2/channelv2.go
CONFLICT (content): Merge conflict in control-plane/pkg/reconciler/channel/v2/channelv2.go
Auto-merging control-plane/pkg/reconciler/channel/channel.go
CONFLICT (content): Merge conflict in control-plane/pkg/reconciler/channel/channel.go
Auto-merging control-plane/pkg/reconciler/broker/broker.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Prevent generation only updates (#3915)
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-v1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pierDipi pierDipi restored the cp-483904b1ef984bdf792dbeba571fda04e5db0963-v1.14 branch August 5, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants