-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-v1.14] Prevent generation only updates (#3915) #1102
[release-v1.14] Prevent generation only updates (#3915) #1102
Conversation
* Prevent generation only contract updates This guards contract ConfigMap updates when only `generation` changes. Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> * Refactor to simplify and remove reconciler level change detection Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> --------- Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/retest |
22b418b
into
openshift-knative:release-v1.14
/cherry-pick release-1.12 |
/cherry-pick release-v1.12 |
@pierDipi: cannot checkout In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@pierDipi: #1102 failed to apply on top of branch "release-v1.12":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Cherry-pick of knative-extensions@483904b