Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v1.13] Remove assumption on default namespace for EventType reference (#7724) #548

Merged
merged 1 commit into from
Mar 5, 2024
Merged

[release-v1.13] Remove assumption on default namespace for EventType reference (#7724) #548

merged 1 commit into from
Mar 5, 2024

Conversation

pierDipi
Copy link
Member

Backport of knative#7724

@pierDipi @Cali0707
Remove assumption on default namespace for EventType reference (knati…
091c1fd 
…ve#7724)

* Remove assumption on default namespace for EventType reference

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Add and fix tests

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>

* Update pkg/reconciler/source/duck/duck_test.go

Co-authored-by: Calum Murray <cmurray@redhat.com>

* Update pkg/reconciler/source/duck/duck_test.go

Co-authored-by: Calum Murray <cmurray@redhat.com>

---------

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Co-authored-by: Calum Murray <cmurray@redhat.com>
@openshift-ci openshift-ci bot requested review from aliok and matzew February 27, 2024 13:33
@pierDipi
Copy link
Member Author

/retest

@pierDipi
Copy link
Member Author

/retest-required

@creydr
Copy link
Member

creydr commented Feb 28, 2024

/retest

creydr
creydr approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 28, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD b1920de and 2 for PR HEAD 091c1fd in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD c2534b2 and 1 for PR HEAD 091c1fd in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 15e55a4 and 0 for PR HEAD 091c1fd in total

@creydr
Copy link
Member

creydr commented Mar 4, 2024

/retest

@creydr
Copy link
Member

creydr commented Mar 4, 2024

/override ci/prow/411-test-e2e-aws-411
as the 4.11 jobs have been removed (see openshift-knative/hack#126)

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 4, 2024

@creydr: Overrode contexts on behalf of creydr: ci/prow/411-test-e2e-aws-411

In response to this:

/override ci/prow/411-test-e2e-aws-411
as the 4.11 jobs have been removed (see openshift-knative/hack#126)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@creydr
Copy link
Member

creydr commented Mar 4, 2024

same here
/override ci/prow/411-test-encryption-auth-e2e-aws-411

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 4, 2024

@creydr: Overrode contexts on behalf of creydr: ci/prow/411-test-encryption-auth-e2e-aws-411

In response to this:

same here
/override ci/prow/411-test-encryption-auth-e2e-aws-411

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

/hold

Revision 091c1fd was retested 3 times: holding

@creydr
Copy link
Member

creydr commented Mar 5, 2024

/retest

2 similar comments
@creydr
Copy link
Member

creydr commented Mar 5, 2024

/retest

@creydr
Copy link
Member

creydr commented Mar 5, 2024

/retest

@creydr
Copy link
Member

creydr commented Mar 5, 2024

/test 412-test-reconciler-aws-412

@creydr
Copy link
Member

creydr commented Mar 5, 2024

/unhold

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 5, 2024 •
edited
Loading

@pierDipi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/411-test-encryption-auth-e2e-aws-411 091c1fd link true /test 411-test-encryption-auth-e2e-aws-411

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 15e55a4 and 2 for PR HEAD 091c1fd in total

@openshift-merge-bot openshift-merge-bot bot merged commit fa0a998 into openshift-knative:release-v1.13 Mar 5, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@creydr creydr creydr approved these changes

@aliok aliok Awaiting requested review from aliok

@matzew matzew Awaiting requested review from matzew

Assignees

@creydr creydr

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pierDipi @creydr @openshift-ci-robot