Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[serverless-1.31] patch func deploy task for serverless 1.31.0 #714

Conversation

serverless-qe
Copy link

patch for func-deploy task to use midstream specific client built for 1.31.0

@codecov-commenter
Copy link

codecov-commenter commented Oct 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (serverless-1.31@7bb474c). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                Coverage Diff                 @@
##             serverless-1.31     #714   +/-   ##
==================================================
  Coverage                   ?   57.53%           
==================================================
  Files                      ?      107           
  Lines                      ?    13835           
  Branches                   ?        0           
==================================================
  Hits                       ?     7960           
  Misses                     ?     5057           
  Partials                   ?      818           
Flag Coverage Δ
e2e-test 36.47% <0.00%> (?)
e2e-test-oncluster-runtime 25.60% <0.00%> (?)
e2e-test-runtime-node 26.92% <0.00%> (?)
e2e-test-runtime-quarkus 27.03% <0.00%> (?)
e2e-test-runtime-springboot 26.06% <0.00%> (?)
e2e-test-runtime-typescript 27.03% <0.00%> (?)
unit-tests-macos-latest 48.64% <0.00%> (?)
unit-tests-windows-latest 48.64% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@serverless-qe serverless-qe force-pushed the serverless-qe/func-deploy-task-serverless-v1.31.0 branch 4 times, most recently from f616a84 to 2ae27a6 Compare November 9, 2023 14:42
Copy link
Collaborator

@dsimansk dsimansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

Copy link

openshift-ci bot commented Nov 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, serverless-qe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 9, 2023
@serverless-qe serverless-qe force-pushed the serverless-qe/func-deploy-task-serverless-v1.31.0 branch from 2ae27a6 to fa036a4 Compare November 10, 2023 17:50
@openshift-ci openshift-ci bot removed the lgtm label Nov 10, 2023
Copy link

openshift-ci bot commented Nov 10, 2023

New changes are detected. LGTM label has been removed.

@serverless-qe serverless-qe force-pushed the serverless-qe/func-deploy-task-serverless-v1.31.0 branch from fa036a4 to 24ff2bc Compare November 10, 2023 22:48
@serverless-qe serverless-qe force-pushed the serverless-qe/func-deploy-task-serverless-v1.31.0 branch from 24ff2bc to 387d500 Compare November 13, 2023 09:46
@jrangelramos jrangelramos merged commit baefc56 into serverless-1.31 Feb 7, 2024
20 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants