Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[serverless-1.31] NPE fix #723

Merged
merged 1 commit into from
Nov 1, 2023
Merged

[serverless-1.31] NPE fix #723

merged 1 commit into from
Nov 1, 2023

Conversation

matejvasek
Copy link
Collaborator

No description provided.

Signed-off-by: Matej Vasek <mvasek@redhat.com>
@matejvasek matejvasek removed the request for review from dsimansk November 1, 2023 16:22
@openshift-ci openshift-ci bot added the approved label Nov 1, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (serverless-1.31@9fbd7c9). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                Coverage Diff                 @@
##             serverless-1.31     #723   +/-   ##
==================================================
  Coverage                   ?   55.19%           
==================================================
  Files                      ?      107           
  Lines                      ?    14535           
  Branches                   ?        0           
==================================================
  Hits                       ?     8023           
  Misses                     ?     5684           
  Partials                   ?      828           
Flag Coverage Δ
e2e-test 36.47% <0.00%> (?)
e2e-test-oncluster-runtime 24.36% <0.00%> (?)
e2e-test-runtime-go 25.89% <0.00%> (?)
e2e-test-runtime-springboot 26.06% <0.00%> (?)
unit-tests-ubuntu-latest 49.40% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jrangelramos
Copy link

/lgtm

Copy link

openshift-ci bot commented Nov 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jrangelramos, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jrangelramos,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matejvasek
Copy link
Collaborator Author

/override "On Cluster Test (1.20.2, ubuntu-latest)"

Copy link

openshift-ci bot commented Nov 1, 2023

@matejvasek: Overrode contexts on behalf of matejvasek: On Cluster Test (1.20.2, ubuntu-latest)

In response to this:

/override "On Cluster Test (1.20.2, ubuntu-latest)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@matejvasek
Copy link
Collaborator Author

/override"Integration Test (1.20.2, ubuntu-latest)"

@matejvasek
Copy link
Collaborator Author

/override "Integration Test (1.20.2, ubuntu-latest)"

Copy link

openshift-ci bot commented Nov 1, 2023

@matejvasek: Overrode contexts on behalf of matejvasek: Integration Test (1.20.2, ubuntu-latest)

In response to this:

/override "Integration Test (1.20.2, ubuntu-latest)"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot merged commit 6aca370 into serverless-1.31 Nov 1, 2023
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants