Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[serverless-1.34] fix: allow sub-pkgs in Go functions #911

Merged
merged 4 commits into from
Sep 27, 2024

Conversation

matejvasek
Copy link
Collaborator

No description provided.

Signed-off-by: Matej Vašek <matejvasek@gmail.com>
Signed-off-by: Matej Vašek <matejvasek@gmail.com>
@matejvasek matejvasek changed the title fix: allow sub-pkgs in Go functions [serverless-1.34] fix: allow sub-pkgs in Go functions Sep 26, 2024
@matejvasek matejvasek requested review from matzew, gauron99, lkingland and jrangelramos and removed request for rhuss and nainaz September 26, 2024 17:18
Signed-off-by: Matej Vašek <matejvasek@gmail.com>
Signed-off-by: Matej Vašek <matejvasek@gmail.com>
@matejvasek
Copy link
Collaborator Author

/test 416-e2e-oncluster-test

@matejvasek
Copy link
Collaborator Author

cc @dsimansk

@dsimansk
Copy link
Collaborator

/lgtm

Copy link

openshift-ci bot commented Sep 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, lkingland, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dsimansk,lkingland,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matejvasek matejvasek merged commit 9c86c1d into serverless-1.34 Sep 27, 2024
21 of 22 checks passed
@dsimansk dsimansk deleted the fix-go-scaffolding-pkgs-ocp branch September 27, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants