This repository has been archived by the owner on Dec 3, 2019. It is now read-only.
Refactor things to clarify which functions are for which platform #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also introduces the idea of configuring the resources *before* they're applied, which in hindsight makes more sense, i.e. make the first configmap the controllers see the correct one. We may want to do the same for the config in the Install CR, but because I'm still unsure whether having the config in there at all is a good idea, I'm keeping it post-install, mostly because the logging is set up to show previous values of whatever it overwrites. Doing that pre-install would require manifestival enhancements. Another thing pre-install config solves is swimming upstream against the controller-runtime caching client, which occasionally fails to find newly-created resources as the informer doesn't yet know about them. See kubernetes-sigs/controller-runtime#180 for more info.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also introduces the idea of configuring the resources before
they're applied, which in hindsight makes more sense, i.e. make the
first configmap the controllers see the correct one.
We may want to do the same for the config in the Install CR, but
because I'm still unsure whether having the config in there at all is
a good idea, I'm keeping it post-install, mostly because the logging
is set up to show previous values of whatever it overwrites. Doing
that pre-install would require manifestival enhancements.
Another thing pre-install config solves is swimming upstream against
the controller-runtime caching client, which occasionally fails to
find newly-created resources as the informer doesn't yet know about
them.
See kubernetes-sigs/controller-runtime#180
for more info.