Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use s2i GA image and update buildah image to latest released #2366

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

Kaustubh-pande
Copy link
Contributor

as per title
cc @mgencur @dsimansk

@Kaustubh-pande
Copy link
Contributor Author

/retest

@mgencur
Copy link
Contributor

mgencur commented Nov 1, 2023

Just a note. We don't have any tests in s-o to verify that this new image actually works. I'm not sure if we should merge it now or after verifying (somewhere else) that this stuff works.

@dsimansk
Copy link
Contributor

dsimansk commented Nov 1, 2023

@Kaustubh-pande perhaps we can try to verify it through func midstream rep. @jrangelramos FYI & PTAL.

@skonto
Copy link
Contributor

skonto commented Nov 1, 2023

/test 4.13-operator-e2e-aws-ocp-413

@Kaustubh-pande
Copy link
Contributor Author

/retest

@Kaustubh-pande
Copy link
Contributor Author

/cherry-pick release-1.31

@openshift-cherrypick-robot
Copy link
Contributor

@Kaustubh-pande: once the present PR merges, I will cherry-pick it on top of release-1.31 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.31

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mgencur
Copy link
Contributor

mgencur commented Nov 2, 2023

/lgtm

Copy link
Contributor

openshift-ci bot commented Nov 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Kaustubh-pande, mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 2, 2023
@openshift-ci openshift-ci bot merged commit 820b025 into openshift-knative:main Nov 2, 2023
19 checks passed
@openshift-cherrypick-robot
Copy link
Contributor

@Kaustubh-pande: new pull request created: #2367

In response to this:

/cherry-pick release-1.31

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants