-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move from go 1.17 to go1.18 #295
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: swatisehgal The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
CI fails when it runs
|
/retest |
/cc |
@@ -1,6 +1,6 @@ | |||
module github.com/openshift-kni/numaresources-operator | |||
|
|||
go 1.17 | |||
go 1.18 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you may want to pull RTE 0.6.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, thanks for cutting a release on the RTE side!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will update this PR now.
Move from go 1.17 to go1.18 Ran `go mod tidy` Signed-off-by: Swati Sehgal <swsehgal@redhat.com>
Signed-off-by: Swati Sehgal <swsehgal@redhat.com>
Signed-off-by: Swati Sehgal <swsehgal@redhat.com>
make sure to clean up your local |
Signed-off-by: Swati Sehgal <swsehgal@redhat.com>
Thanks for that, yeah the issue is reproducing locally. |
Looks like this is a known issue :kubernetes-sigs/kubebuilder#2530. The reason of the failure is because kubebuilder does not support go 1.18 yet: kubernetes-sigs/kubebuilder#2561. |
to move forward, I'd be in favour of applying a local fix like
I think this is actually something we can carry for the time being. |
As of today, Kube-builder does not support go 1.18: kubernetes-sigs/kubebuilder#2561. Also, note that installing executables with go get is deprecated in go1.18 (xref:https://go.dev/doc/go-get-install-deprecation). Co-authored-by: Francesco Romani <fromani@redhat.com> Signed-off-by: Swati Sehgal <swsehgal@redhat.com>
I'm in favour of moving to the latest kustomize v4. I'm not aware of any regression this would cause, and a quick glance at the changes between v3.8 and v4.5 revealed blockers. |
Good catch actually, I over-enthisiastically pushed the changes without testing locally, staying with Kustomize version 3.8.7 is giving me the error as linked in the issue and the one we are getting in the CI as well:
I think the issue you linked has been resolved after removing excluded dependencies from kustomize go mod: |
Posting the fix shortly. |
Signed-off-by: Swati Sehgal <swsehgal@redhat.com>
/lgtm |
go mod tidy