Enable network service in RHEL8 #689
Conversation
02_configure_host.sh
Outdated
| @@ -111,6 +111,9 @@ if [ "$MANAGE_INT_BRIDGE" == "y" ]; then | |||
| else | |||
| sudo systemctl restart network | |||
| fi | |||
| if [ "${RHEL8}" = "True" ] ; then | |||
| sudo systemctl enable network | |||
| fi | |||
There was a problem hiding this comment.
I'm wondering how this ends up disabled? Was it a manual ISO install where no network was activated as part of the install?
Regardless this seems unrelated to the OS version, perhaps we should just unconditionally enable then restart it, to remove the restart duplication above?
There was a problem hiding this comment.
Ah I see the restart de-duplication is handled in #690 thanks!
There was a problem hiding this comment.
I've added the enable only if the ifcfg-* files are modified
There was a problem hiding this comment.
Is the network service only for handling ifcfg scripts? In RHEL8 that's not installed by default. We install it so we can still use ifcfg scripts. That's probably why it has to be enabled in RHEL8 and we didn't see that before.
In RHEL8 it is disabled by default. Fixes #688
| # If there were modifications to the /etc/sysconfig/network-scripts/ifcfg-* | ||
| # files, it is required to enable the network service | ||
| if [ "$MANAGE_INT_BRIDGE" == "y" ] || [ "$MANAGE_PRO_BRIDGE" == "y" ]; then | ||
| sudo systemctl enable network |
There was a problem hiding this comment.
I suspect this was only needed for RHEL8 since we install network-scripts for ifcfg file support, which isn't there by default. I suppose this is harmless elsewhere though.
|
This is fine, but I can't help wondering if we should just move to nmcli for RHEL8 instead? Here's an example of configuring an interface with nmcli: Not blocking this as a quick-fix, but wanted to have that discussion and now seems a good time to mention it :) |
|
+1 to moving to network manager for all of this!
|
|
Can we have this merged then create an issue to track the NetworkManager modifications? Thanks! (also, TIL about https://github.com/nmstate/nmstate) |
Sure, and yes maybe nmstate would be a nice thing to investigate as an alternative to shell hacking :) |
It is disabled by default in RHEL8
Fixes #688