[WIP]support manifest bundle. #57
Conversation
| @@ -60,6 +63,15 @@ func (d *Resource) GetDeletionTimestamp() *metav1.Time { | |||
| return &metav1.Time{Time: d.Meta.DeletedAt.Time} | |||
| } | |||
|
|
|||
| func (d *Resource) HasManifestBundle() bool { | |||
| if d.Manifest != nil { | |||
| if kind, ok := d.Manifest["kind"]; ok && kind == "ManifestWork" { | |||
There was a problem hiding this comment.
inspecting the payload for exactly and only one kind of resource smells to me because it's implicit. if Maestro wishes to support many resources in 1 API call, perhaps that should be part of the official API/openapi?
There was a problem hiding this comment.
Apologies for any confusion. Currently, Maestro still only supports a single resource per API call.
This functionality in this PR is intended solely for internal use, specifically when Maestro accepts gRPC calls. Each API call should include a manifestwork, which, in turn, contains a bundle.
However, it's important to note that each API call is designed to handle only one manifestwork.
There was a problem hiding this comment.
Yes, I understand the desire to go from 1 to Many objects in the payload. I'm suggesting it's better to have that explicit in the API than an implicit string search like this.
Specifically, the Resource struct has the single Manifest attribute on it. In order to make this Many, perhaps a ResourceSet object is the correct one to introduce and it specifically has either many Resources (our Kind) or many Manifests.
morvencao
force-pushed
the
br_manifest_bundle_support
branch
3 times, most recently
from
63c8e9d to
c5cc4ac
Compare
Signed-off-by: morvencao <lcao@redhat.com>
morvencao
force-pushed
the
br_manifest_bundle_support
branch
from
c5cc4ac to
f97d4e9
Compare
|
appended test results: # make test-integration
CGO_ENABLED=1 GOEXPERIMENT=boringcrypto go install -ldflags="" ./cmd/maestro
OCM_ENV=testing gotestsum --format short-verbose -- -p 1 -ldflags -s -v -timeout 1h \
./test/integration
I0301 04:57:37.425164 160941 framework.go:76] Initializing testing environment
I0301 04:57:37.683783 160941 framework.go:161] Using Mock OCM Authz Client
I0301 04:57:37.685950 160941 framework.go:199] Disabling Sentry error reporting
I0301 04:57:37.694039 160941 grpc_server.go:78] Serving gRPC service without TLS at 8090
PASS test/integration.TestConsumerGet (0.30s)
PASS test/integration.TestConsumerPost (0.21s)
PASS test/integration.TestConsumerPaging (0.32s)
PASS test/integration.TestControllerRacing (1.63s)
PASS test/integration.TestControllerReconcile (1.32s)
PASS test/integration.TestControllerSync (1.31s)
PASS test/integration.TestPulseServer (5.20s)
PASS test/integration.TestResourceGet (0.33s)
PASS test/integration.TestResourcePost (5.33s)
PASS test/integration.TestResourcePatch (0.28s)
PASS test/integration.TestResourcePaging (0.45s)
PASS test/integration.TestResourceListSearch (0.41s)
PASS test/integration.TestUpdateResourceWithRacingRequests (0.30s)
PASS test/integration.TestResourceFromGRPC (6.41s)
I0301 04:58:01.523191 160941 api_server.go:157] Web server terminated
PASS test/integration
DONE 14 tests in 1.054s |
|
/assign @qiujian16 @clyang82 @skeeey |
|
closing this in favor of #59 |
ref: https://issues.redhat.com/browse/OCM-6367
depend on: open-cluster-management-io/ocm#352