Honor @http annotation for query parameters
#197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhernand
added a commit
to jhernand/ocm-api-model
that referenced
this pull request
Jun 22, 2023
Currently we are using the `@json` annotation to force the name of the dry run query parameter to `dryRun`. But this is incorrect, and only works because of a bug in the metamodel that is going to be fixed. This patch replaces `@json` with `@http` which will work after the bug is fixed. Related: openshift-online/ocm-api-metamodel#197 Signed-off-by: Juan Hernandez <juan.hernandez@redhat.com>
jhernand
added a commit
to jhernand/ocm-api-model
that referenced
this pull request
Jun 22, 2023
Currently we are using the `@json` annotation to force the name of the dry run query parameter to `dryRun`. But this is incorrect, and only works because of a bug in the metamodel that is going to be fixed. This patch replaces `@json` with `@http` which will work after the bug is fixed. Related: openshift-online/ocm-api-metamodel#197 Signed-off-by: Juan Hernandez <juan.hernandez@redhat.com>
jhernand
force-pushed
the
honor_http_annotation_in_query_parameters
branch
from
9d90305
to
5cf844b
Compare
Currently the `@http` annotation is ignored for query parameters. We are using `@json` instead. That is a bug, and this patch fixes it. Signed-off-by: Juan Hernandez <juan.hernandez@redhat.com>
jhernand
force-pushed
the
honor_http_annotation_in_query_parameters
branch
from
5cf844b
to
4998940
Compare
|
Given - in fetchLabels Boolean
+ @http(name = "fetchLabels")
+ in FetchLabels Boolean
@@ "parameters": [
- "name": "fetchlabels_labels",
+ "name": "fetchLabels",
-// FetchlabelsLabels sets the value of the 'fetchlabels_labels' parameter.
-func (r *SubscriptionsListRequest) FetchlabelsLabels(value bool) *SubscriptionsListRequest {
+// FetchLabels sets the value of the 'fetch_labels' parameter.
+func (r *SubscriptionsListRequest) FetchLabels(value bool) *SubscriptionsListRequest {
...
- helpers.AddValue(&query, "fetchlabels_labels", *r.fetchlabelsLabels)
+ helpers.AddValue(&query, "fetchLabels", *r.fetchLabels)
|
cben
added a commit
to cben/ocm-api-model
that referenced
this pull request
Jun 22, 2023
Requires metamodel >= 0.0.59 to respect the annotation (openshift-online/ocm-api-metamodel#197) However, generated names before were wrong anyway.
cben
added a commit
to cben/ocm-api-model
that referenced
this pull request
Jun 23, 2023
Requires metamodel >= 0.0.59 to respect the annotation (openshift-online/ocm-api-metamodel#197) However, generated names before were wrong anyway.
tzvatot
pushed a commit
to tzvatot/ocm-api-model
that referenced
this pull request
Jul 24, 2023
Requires metamodel >= 0.0.59 to respect the annotation (openshift-online/ocm-api-metamodel#197) However, generated names before were wrong anyway.
tzvatot
pushed a commit
to tzvatot/ocm-api-model
that referenced
this pull request
Jul 24, 2023
Currently we are using the `@json` annotation to force the name of the dry run query parameter to `dryRun`. But this is incorrect, and only works because of a bug in the metamodel that is going to be fixed. This patch replaces `@json` with `@http` which will work after the bug is fixed. Related: openshift-online/ocm-api-metamodel#197 Signed-off-by: Juan Hernandez <juan.hernandez@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
@httpannotation is ignored for query parameters. We are using@jsoninstead. That is a bug, and this patch fixes it.