[DNM] [Backport] Make sure to check if we can make API calls #1700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We didn't check for the error, which could crash the tekton controller. That call is the first API call we make so is the first one that would crash. Report the run as error if that happen, since it's probably a GitHub API outage (and a lot of other things would be wrong) Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
Fix yamllint error backpport to 0.24.x for ci to green
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-v0.24.x #1700 +/- ##
===================================================
- Coverage 63.19% 63.17% -0.02%
===================================================
Files 139 139
Lines 10762 10762
===================================================
- Hits 6801 6799 -2
- Misses 3436 3438 +2
Partials 525 525 ☔ View full report in Codecov by Sentry. |
chmouel
changed the title
and do a sync.RLock while using it to make sure this don't go off the rails (altho that's should not be absolutely necessary) https://issues.redhat.com/browse/SRVKP-5507 Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That call is the first API call we make so is the first one that would
crash. Report the run as error if that happen, since it's probably a
GitHub API outage (and a lot of other things would be wrong)
Signed-off-by: Chmouel Boudjnah chmouel@redhat.com# Changes
Submitter Checklist
📝 Please ensure your commit message is clear and informative. For guidance on crafting effective commit messages, refer to the How to write a git commit message guide. We prefer the commit message to be included in the PR body itself rather than a link to an external website (ie: Jira ticket).
♽ Before submitting a PR, run make test lint to avoid unnecessary CI processing. For an even more efficient workflow, consider installing pre-commit and running pre-commit install in the root of this repository.
✨ We use linters to maintain clean and consistent code. Please ensure you've run make lint before submitting a PR. Some linters offer a --fix mode, which can be executed with the command make fix-linters (ensure markdownlint and golangci-lint tools are installed first).
📖 If you're introducing a user-facing feature or changing existing behavior, please ensure it's properly documented.
🧪 While 100% coverage isn't a requirement, we encourage unit tests for any code changes where possible.
🎁 If feasible, please check if an end-to-end test can be added. See README for more details.
🔎 If there's any flakiness in the CI tests, don't necessarily ignore it. It's better to address the issue before merging, or provide a valid reason to bypass it if fixing isn't possible (e.g., token rate limitations).