-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-16418: Show more clear info about the DeploymentConfig is deprecated #1837
base: master
Are you sure you want to change the base?
Conversation
Hello @sanchezl! Some important instructions when contributing to openshift/api: |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sanchezl The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Proof PR: openshift/kubernetes#1921 |
@sanchezl: This pull request references Jira Issue OCPBUGS-16418, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
e669420
to
547493a
Compare
547493a
to
5cd8fa5
Compare
@sanchezl: This pull request references Jira Issue OCPBUGS-16418, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@sanchezl: This pull request references Jira Issue OCPBUGS-16418, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/jira refresh |
@sanchezl: This pull request references Jira Issue OCPBUGS-16418, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
// +k8s:prerelease-lifecycle-gen:deprecated=4.14 | ||
// +k8s:prerelease-lifecycle-gen:removed=4.10000 | ||
// +k8s:prerelease-lifecycle-gen:introduced=1.1 | ||
// +k8s:prerelease-lifecycle-gen:deprecated=1.27 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: the versioning was originally intentionally set to follow the openshift versioning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood, but we are making use of upstream functionality that only truly understands kubernetes versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DCs is an OpenShift resource. It's kinda strange to claim an OpenShift resources was deprecated in Kubernetes.
// +k8s:prerelease-lifecycle-gen:removed=4.10000 | ||
// +k8s:prerelease-lifecycle-gen:introduced=1.1 | ||
// +k8s:prerelease-lifecycle-gen:deprecated=1.27 | ||
// +k8s:prerelease-lifecycle-gen:removed=0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, if this removes the removed part in the message => ++
The warning message is definitely annoying. +1 for removing it when listing all resources. I'd still prefer to keep it when CRUD'ing the DC resource. |
@ingvagabund I've opened a companion PR to remove the message completely from |
@sanchezl: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
With these settings the warning header should change from this:
to
Open question:
Given that this type is never actually going to be removed, should we just remove the deprecation warning?
Marking it as deprecated, usually starts the clock towards removal.