Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPNODE-2358: Update (cluster)imagepolicy doc no restriction on release repo scopes #1927

Merged
merged 1 commit into from
Jul 4, 2024
Merged

OCPNODE-2358: Update (cluster)imagepolicy doc no restriction on release repo scopes #1927

merged 1 commit into from
Jul 4, 2024

Conversation

QiWang19
Copy link
Member

@QiWang19 QiWang19 commented Jun 11, 2024 •
edited
Loading

openshift/machine-config-operator#4401 implementation removes the restriction that scopes field can not be set for OCP release payload repo to support openshift/enhancements#1633.
Remove the godoc comment from (Cluster)imagepolicy docs to stay compatible with the implementation of this change.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 11, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 11, 2024 •
edited by openshift-ci bot
Loading

@QiWang19: This pull request references OCPNODE-2358 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

openshift/machine-config-operator#4401 implementation removes the restriction that scopes field can not be set for OCP release payload repo.
Remove the godoc comment from (Cluster)imagepolicy docs to stay compatible with the implementation of this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 11, 2024

Hello @QiWang19! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 11, 2024
@QiWang19
Copy link
Member Author

/test verify

@QiWang19
Copy link
Member Author

@JoelSpeed @deads2k could you review? The documented restriction was removed from the implementation to support openshift/enhancements#1633. This PR will keep the doc up to date.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 18, 2024 •
edited by openshift-ci bot
Loading

@QiWang19: This pull request references OCPNODE-2358 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

openshift/machine-config-operator#4401 implementation removes the restriction that scopes field can not be set for OCP release payload repo to support openshift/enhancements#1633.
Remove the godoc comment from (Cluster)imagepolicy docs to stay compatible with the implementation of this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@QiWang19
Copy link
Member Author

@mtrmac PTAL

mtrmac
mtrmac reviewed Jun 18, 2024
View reviewed changes
Copy link
Contributor

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK in the sense that this matches the MCO change.

I’ve previously demonstrated to be ignorant of k8s API rules, so I’d prefer experts to review this PR :)

@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 25, 2024
@QiWang19
Copy link
Member Author

@mtrmac Added the doc about the longest path match and warning information about the openshift repository.
Could you review it?

mtrmac
mtrmac reviewed Jun 25, 2024
View reviewed changes
Copy link
Contributor

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The note about matching the most specific scope is definitely valuable.

@QiWang19
Update (cluster)imagepolicy doc no restriction on release repo scopes
d7b7087 
Update the (Cluster)imagepolicy docs to stay compatible with the implementation change

Signed-off-by: Qi Wang <qiwan@redhat.com>
wking
wking approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 2, 2024
@JoelSpeed
Copy link
Contributor

/lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, QiWang19, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 4, 2024

@QiWang19: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 33ed71a into openshift:master Jul 4, 2024
9 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-config-api-container-v4.17.0-202407041312.p0.g33ed71a.assembly.stream.el9 for distgit ose-cluster-config-api.
All builds following this will include this PR.

@QiWang19 QiWang19 mentioned this pull request Jul 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrmac mtrmac mtrmac left review comments

@wking wking wking approved these changes

@deads2k deads2k Awaiting requested review from deads2k

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@wking wking

@JoelSpeed JoelSpeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@QiWang19 @openshift-ci-robot @JoelSpeed @openshift-bot @wking @mtrmac