Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPNODE-2436: SigstoreImageVerification featuregate marker for the ClusterImagePolicy and ImagePolicy #1964

Merged
merged 2 commits into from
Jul 17, 2024
Merged

OCPNODE-2436: SigstoreImageVerification featuregate marker for the ClusterImagePolicy and ImagePolicy #1964

merged 2 commits into from
Jul 17, 2024

Conversation

QiWang19
Copy link
Member

@QiWang19 QiWang19 commented Jul 16, 2024 •
edited
Loading

ClusterImagePolicy and ImagePolicy use SigstoreImageVerification instead of ImagePolicy

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 16, 2024

Hello @QiWang19! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 16, 2024
@deads2k
Copy link
Contributor

deads2k commented Jul 16, 2024

Is the ImagePolicy featureGate in use? if not, please remove it here.

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 16, 2024
wking
wking approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2024
@deads2k
Copy link
Contributor

deads2k commented Jul 16, 2024

/approve

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed lgtm Indicates that a PR is ready to be merged. labels Jul 16, 2024
@QiWang19
SigstoreImageVerification feature gatemarker for the ClusterImagePoli…
d68bab0 
…cy and ImagePolicy

Signed-off-by: Qi Wang <qiwan@redhat.com>
@QiWang19
Drop ImagePolicy featuregate
34cb805 
Signed-off-by: Qi Wang <qiwan@redhat.com>
@QiWang19
Copy link
Member Author

/retest

@QiWang19
Copy link
Member Author

/test integration

@QiWang19
Copy link
Member Author

/test verify

@wking
Copy link
Member

wking commented Jul 16, 2024

/retest-required

@jupierce
Copy link
Contributor

/test all

@QiWang19
Copy link
Member Author

/retest

wking
wking approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, QiWang19, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wking
Copy link
Member

wking commented Jul 17, 2024 •
edited by openshift-ci bot
Loading

/retitle OCPNODE-2436: SigstoreImageVerification featuregate marker for the ClusterImagePolicy and ImagePolicy

@openshift-ci openshift-ci bot changed the title SigstoreImageVerification featuregate marker for the ClusterImagePolicy and ImagePolicy OCPNODE-2436: SigstoreImageVerification featuregate marker for the ClusterImagePolicy and ImagePolicy Jul 17, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 17, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 17, 2024 •
edited by openshift-ci bot
Loading

@QiWang19: This pull request references OCPNODE-2436 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

ClusterImagePolicy and ImagePolicy use SigstoreImageVerification instead of ImagePolicy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 17, 2024

@QiWang19: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rphillips
Copy link
Contributor

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Jul 17, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 8da8de5 into openshift:master Jul 17, 2024
18 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-config-api-container-v4.17.0-202407180110.p0.g8da8de5.assembly.stream.el9 for distgit ose-cluster-config-api.
All builds following this will include this PR.

@wking wking mentioned this pull request Jul 20, 2024
Merged
@QiWang19 QiWang19 mentioned this pull request Jul 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wking wking wking approved these changes

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@wking wking

Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@QiWang19 @deads2k @wking @jupierce @openshift-ci-robot @rphillips @openshift-bot