[release-ocm-2.8] MGMT-18332: Use centos stream 9 as the base image for test container #872
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@danmanor: This pull request references MGMT-18336 which is a valid jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
size/M
openshift-ci
bot
added
downstream-change-needed
danmanor
changed the title
|
@danmanor: This pull request references MGMT-18332 which is a valid jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
danmanor
changed the title
|
/override ci/prow/e2e-ai-operator-ztp |
|
@danmanor: Overrode contexts on behalf of danmanor: ci/prow/e2e-ai-operator-ztp In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
danmanor
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
danmanor
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/remove label downstream-change-needed |
|
/retest |
1 similar comment
|
/retest |
|
/remove-label downstream-change-needed |
openshift-ci
bot
removed
the
downstream-change-needed
|
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-ocm-2.8 #872 +/- ##
================================================
Coverage 54.68% 54.68%
================================================
Files 14 14
Lines 2911 2911
================================================
Hits 1592 1592
Misses 1177 1177
Partials 142 142 |
|
@danmanor: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| containerd.io \ | ||
| make \ | ||
| git \ | ||
| openssl-devel \ |
There was a problem hiding this comment.
Did you check if openssl-devel was needed as well in those repo ?
| make \ | ||
| git \ | ||
| openssl-devel \ | ||
| gcc \ |
There was a problem hiding this comment.
I would also install util-linux explicitly. I think it comes with one of the docker stuff, but without it I had trouble to runner skipper locally
There was a problem hiding this comment.
why would util-linux inside the container would relate to skipper on the host ? I don't need for skipper to work
There was a problem hiding this comment.
skipper is trying to run su command. If it's not part of the Dockerfile.xxx-build image, it fails (at least this is the behavior I have locally)
There was a problem hiding this comment.
it's part of the entrypoint script skipper is launching
There was a problem hiding this comment.
There was a problem hiding this comment.
Oh this is because you are using later version of skipper, I use 2.0.2
There was a problem hiding this comment.
OK lets add it for any case
There was a problem hiding this comment.
I think this problem would occur for you with a lot of other Dockerfiles we use. Maybe add it in different PRs ?
There was a problem hiding this comment.
Although I would recommend using skipper==2.0.2
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danmanor, rccrdpccl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit f8f73a0
into
openshift:release-ocm-2.8
No description provided.