Update baremetal operator #5698

filanov · 2023-11-15T19:40:35Z

MGMT-16047: update baremetal-operator to 4.14

One of the major changes is controlelr-runtime verison

Cache functioanlity updated
Admission decoder does not return an error
Chaning deprecated PollImmediate function to PollUntilContextTimeout
Controller wait funtion signature have changed to get object instead of
kind
Switching pointer package to use generic ptr
Generated webhook validation function signature changed

List all the issues related to this PR

What environments does this code impact?

Automation (CI, tools, etc)
Cloud
Operator Managed Deployments
None

How was this code tested?

assisted-test-infra environment
dev-scripts environment
Reviewer's test appreciated
Waiting for CI to do a full test run
Manual (Elaborate on how it was tested)
No tests needed

Checklist

Title and description added to both, commit and PR.
Relevant issues have been associated (see CONTRIBUTING guide)
This change does not require a documentation update (docstring, docs, README, etc)
Does this change include unit-tests (note that code changes require unit-tests)

Reviewers Checklist

Are the title and description (in both PR and commit) meaningful and clear?
Is there a bug required (and linked) for this change?
Should this PR be backported?

filanov · 2023-11-15T19:41:02Z

/assign @omertuc
/assign @danielerez

openshift-ci · 2023-11-15T19:44:19Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: filanov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [filanov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

codecov · 2023-11-15T20:01:21Z

Codecov Report

Merging #5698 (e5aff9c) into master (270b38b) will increase coverage by 0.01%.
Report is 5 commits behind head on master.
The diff coverage is 9.61%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5698      +/-   ##
==========================================
+ Coverage   67.94%   67.95%   +0.01%     
==========================================
  Files         233      233              
  Lines       34395    34391       -4     
==========================================
+ Hits        23370    23371       +1     
+ Misses       8952     8948       -4     
+ Partials     2073     2072       -1

Files	Coverage Δ
internal/controller/controllers/common.go	`76.25% <ø> (ø)`
internal/hardware/validator.go	`76.49% <100.00%> (ø)`
...nternal/controller/controllers/agent_controller.go	`77.22% <0.00%> (ø)`
...ller/controllers/agentclusterinstall_controller.go	`59.09% <0.00%> (ø)`
...ller/controllers/agentclassification_controller.go	`57.89% <0.00%> (ø)`
...oller/controllers/agentserviceconfig_controller.go	`85.01% <0.00%> (ø)`
...ler/controllers/preprovisioningimage_controller.go	`80.87% <50.00%> (-0.06%)`	⬇️
...al/controller/controllers/agentlabel_controller.go	`57.14% <0.00%> (ø)`
internal/common/common_unitest_db.go	`18.14% <0.00%> (ø)`
...nal/controller/controllers/bmh_agent_controller.go	`75.17% <0.00%> (+0.25%)`	⬆️
... and 2 more

... and 2 files with indirect coverage changes

filanov · 2023-11-16T08:19:34Z

/hold
having issues because of a bug in controller-runtime kubernetes-sigs/controller-runtime#2362

go mod and vendor

One of the major changes is controlelr-runtime verison * Cache functioanlity updated * Admission decoder does not return an error * Chaning deprecated PollImmediate function to PollUntilContextTimeout * Controller wait funtion signature have changed to get object instead of kind * Switching pointer package to use generic ptr * Generated webhook validation function signature changed

filanov · 2023-11-19T14:15:18Z

/unhold

Status.Update will not work unless the resource is added to WithStatusSubresource

filanov · 2023-11-19T21:04:34Z

/retest

filanov · 2023-11-20T08:56:43Z

/hold
webhooks are not working as expected

filanov · 2023-11-20T13:22:48Z