Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-17848: Assisted service should not format multipath devices #6360

Merged

Conversation

adriengentil
Copy link
Contributor

@adriengentil adriengentil commented May 23, 2024

Exclude multipath drive type from being formatted.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 23, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 23, 2024

@adriengentil: This pull request references MGMT-17848 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@adriengentil
Copy link
Contributor Author

/test edge-unit-test edge-lint

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 23, 2024
Copy link

openshift-ci bot commented May 23, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 23, 2024
Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 69.58%. Comparing base (901539c) to head (0aaadc0).
Report is 12 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6360      +/-   ##
==========================================
+ Coverage   68.27%   69.58%   +1.31%     
==========================================
  Files         244      245       +1     
  Lines       35881    38022    +2141     
==========================================
+ Hits        24497    26457    +1960     
- Misses       9221     9274      +53     
- Partials     2163     2291     +128     
Files Coverage Δ
internal/common/disk_formatting.go 0.00% <0.00%> (ø)

... and 13 files with indirect coverage changes

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 23, 2024

@adriengentil: This pull request references MGMT-17848 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to this:

Exclude multipath drive type from being formatted.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@adriengentil
Copy link
Contributor Author

/cc @avishayt

@adriengentil adriengentil marked this pull request as ready for review May 23, 2024 14:47
@openshift-ci openshift-ci bot requested a review from avishayt May 23, 2024 14:47
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 23, 2024
@openshift-ci openshift-ci bot requested a review from eliorerz May 23, 2024 14:53
@gamli75
Copy link
Contributor

gamli75 commented May 27, 2024

/test edge-subsystem-kubeapi-aws

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2024
Copy link

openshift-ci bot commented May 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriengentil, avishayt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adriengentil,avishayt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@adriengentil
Copy link
Contributor Author

/cherry-pick ocm-release-2.10 ocm-release-2.9 ocm-release-2.8

@openshift-cherrypick-robot

@adriengentil: once the present PR merges, I will cherry-pick it on top of ocm-release-2.10 in a new PR and assign it to you.

In response to this:

/cherry-pick ocm-release-2.10 ocm-release-2.9 ocm-release-2.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 8a63485 and 2 for PR HEAD 0aaadc0 in total

@adriengentil
Copy link
Contributor Author

/retest

Copy link

openshift-ci bot commented May 27, 2024

@adriengentil: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit ffa8b5c into openshift:master May 27, 2024
14 checks passed
@openshift-cherrypick-robot

@adriengentil: cannot checkout ocm-release-2.10: error checking out "ocm-release-2.10": exit status 1 error: pathspec 'ocm-release-2.10' did not match any file(s) known to git

In response to this:

/cherry-pick ocm-release-2.10 ocm-release-2.9 ocm-release-2.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-agent-installer-api-server-container-v4.17.0-202405272342.p0.gffa8b5c.assembly.stream.el9 for distgit ose-agent-installer-api-server.
All builds following this will include this PR.

@adriengentil
Copy link
Contributor Author

/cherry-pick ocm-release-2.10 ocm-release-2.9 ocm-release-2.8

@adriengentil
Copy link
Contributor Author

/cherry-pick release-ocm-2.10 release-ocm-2.9 release-ocm-2.8

@openshift-cherrypick-robot

@adriengentil: cannot checkout ocm-release-2.10: error checking out "ocm-release-2.10": exit status 1 error: pathspec 'ocm-release-2.10' did not match any file(s) known to git

In response to this:

/cherry-pick ocm-release-2.10 ocm-release-2.9 ocm-release-2.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@adriengentil: new pull request created: #6380

In response to this:

/cherry-pick release-ocm-2.10 release-ocm-2.9 release-ocm-2.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@adriengentil adriengentil mentioned this pull request Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants