-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MGMT-17848: Assisted service should not format multipath devices #6360
MGMT-17848: Assisted service should not format multipath devices #6360
Conversation
@adriengentil: This pull request references MGMT-17848 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/test edge-unit-test edge-lint |
Skipping CI for Draft Pull Request. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6360 +/- ##
==========================================
+ Coverage 68.27% 69.58% +1.31%
==========================================
Files 244 245 +1
Lines 35881 38022 +2141
==========================================
+ Hits 24497 26457 +1960
- Misses 9221 9274 +53
- Partials 2163 2291 +128
|
@adriengentil: This pull request references MGMT-17848 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/cc @avishayt |
/test edge-subsystem-kubeapi-aws |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adriengentil, avishayt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick ocm-release-2.10 ocm-release-2.9 ocm-release-2.8 |
@adriengentil: once the present PR merges, I will cherry-pick it on top of ocm-release-2.10 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/retest |
@adriengentil: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@adriengentil: cannot checkout In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[ART PR BUILD NOTIFIER] This PR has been included in build ose-agent-installer-api-server-container-v4.17.0-202405272342.p0.gffa8b5c.assembly.stream.el9 for distgit ose-agent-installer-api-server. |
/cherry-pick ocm-release-2.10 ocm-release-2.9 ocm-release-2.8 |
/cherry-pick release-ocm-2.10 release-ocm-2.9 release-ocm-2.8 |
@adriengentil: cannot checkout In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@adriengentil: new pull request created: #6380 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Exclude multipath drive type from being formatted.