Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] SDCICD-1241 enforce sync between operator version vars and operator branch names #338

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP] SDCICD-1241 enforce sync between operator version vars and operator branch names #338

wants to merge 1 commit into from
+15 −3

Conversation

ritmun
Copy link
Contributor

@ritmun ritmun commented Feb 17, 2024 •
edited by openshift-ci bot
Loading

  • sets up ocp promotion in prow-config - this creates ocp version branches
  • adds branch-version-check to validate target
  • reads version from makefile, checks out version branch - builds image on it
  • if branch isn't found, exits with error message

SDCICD-1202
SDCICD-1241

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 17, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ritmun
Once this PR has been reviewed and has the lgtm label, please assign jharrington22 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ritmun ritmun closed this Feb 17, 2024
@ritmun ritmun reopened this Feb 19, 2024
@ritmun ritmun changed the title [WIP] spike: enforce branching model for operator repositories [WIP] spike: enforce versioning for operator repositories Feb 19, 2024
@ritmun ritmun changed the title [WIP] spike: enforce versioning for operator repositories [WIP] spike: enforce branch-version sync for operator repositories Feb 19, 2024
@ritmun ritmun changed the title [WIP] spike: enforce branch-version sync for operator repositories [WIP] spike: enforce sync between branch name and operator version tag Feb 19, 2024
@ritmun ritmun changed the title [WIP] spike: enforce sync between branch name and operator version tag [WIP] spike: enforce sync between operator version vars, branch names and ocp version branches Feb 20, 2024
@ritmun ritmun changed the title [WIP] spike: enforce sync between operator version vars, branch names and ocp version branches [WIP] spike: enforce sync between operator version vars, branch names and ocp versioning Feb 20, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 20, 2024

@ritmun: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ritmun ritmun changed the title [WIP] spike: enforce sync between operator version vars, branch names and ocp versioning [WIP] SDCICD-1241 enforce sync between operator version vars, branch names and ocp versioning Mar 15, 2024
@ritmun ritmun changed the title [WIP] SDCICD-1241 enforce sync between operator version vars, branch names and ocp versioning [WIP] SDCICD-1241 enforce sync between operator version vars and operator branch names Mar 15, 2024
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 14, 2024
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 14, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 14, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustman9000 dustman9000 Awaiting requested review from dustman9000

@jharrington22 jharrington22 Awaiting requested review from jharrington22

Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ritmun @openshift-bot @openshift-merge-robot