Skip to content

Commit

Permalink
CONTRIBUTING: watch controller-manager deployment, not daemonset
Browse files Browse the repository at this point in the history
Not sure on the history there, but there are no daemonsets nowadays in
the openshift-controller-manager namespace. There's a deployment object
though and I see it cycle the pods when patching the builder pod, so I
assume that's the correct object to watch now.
  • Loading branch information
jlebon committed Nov 12, 2024
1 parent e69b42c commit 8981226
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ $ oc patch configmap openshift-controller-manager-images -n openshift-controller
6. Watch the openshift controller manager pods rollout (this can take a few minutes):

```
$ oc get ds controller-manager -n openshift-controller-manager -w
$ oc get deployment controller-manager -n openshift-controller-manager -w
```

7. Trigger an OpenShift build via `oc start-build`. You can use one of the templates suggested in `oc new-app` to populate your project with a build.
Expand Down

0 comments on commit 8981226

Please sign in to comment.