-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pod-scaler: add labels to Build Pods via admission #1895
pod-scaler: add labels to Build Pods via admission #1895
Conversation
b313c28
to
ea1799e
Compare
8a61d19
to
dadea75
Compare
...caler/testdata/zz_fixture_TestMutatePods_pod_associated_with_a_build_that_has_no_labels.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
/hold I want this: kubernetes-sigs/controller-runtime#1429 |
dadea75
to
9ab283a
Compare
928b215
to
3149ff2
Compare
/hold cancel |
3149ff2
to
3e31dbe
Compare
@petr-muller @alvaroaleman this is ready for review again now |
/retest |
/hold |
We need labels on Pods to associate individual executions with their semantic category. Today, we label Builds (as that's what we create) but the Build subsystem does not carry those labels forward to the Pods that implement the Build. This patch adds a new mutating admission webhook server that will add the labels where necessary. Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
3e31dbe
to
9b9d2cb
Compare
lol |
Part of DPTP-1822 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, petr-muller, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
We need labels on Pods to associate individual executions with their
semantic category. Today, we label Builds (as that's what we create) but
the Build subsystem does not carry those labels forward to the Pods that
implement the Build. This patch adds a new mutating admission webhook
server that will add the labels where necessary.
Signed-off-by: Steve Kuznetsov skuznets@redhat.com
/assign @petr-muller @alvaroaleman