Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github-ldap-user-group-creator: include a group with all rover usernames #4208

Closed
wants to merge 1 commit into from

Conversation

droslean
Copy link
Member

@droslean droslean commented Jul 1, 2024

This change will allow the tool to create the group redhat-rover-users to all clusters that will hold ALL rover users.

/cc @openshift/test-platform @hongkailiu

Signed-off-by: Nikolaos Moraitis nmoraiti@redhat.com

Signed-off-by: Nikolaos Moraitis <nmoraiti@redhat.com>
Copy link
Contributor

openshift-ci bot commented Jul 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: droslean

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2024
@hongkailiu
Copy link
Member

@droslean
Copy link
Member Author

droslean commented Jul 1, 2024

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 1, 2024
Copy link
Contributor

openshift-ci bot commented Jul 1, 2024

@droslean: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images 1359722 link true /test images
ci/prow/breaking-changes 1359722 link false /test breaking-changes
ci/prow/checkconfig 1359722 link true /test checkconfig
ci/prow/lint 1359722 link true /test lint
ci/prow/integration 1359722 link true /test integration
ci/prow/security 1359722 link false /test security
ci/prow/unit 1359722 link true /test unit
ci/prow/frontend-checks 1359722 link true /test frontend-checks

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@droslean
Copy link
Member Author

/close

@droslean droslean closed this Jul 30, 2024
@droslean droslean deleted the rover-groups branch July 30, 2024 10:04
Copy link
Contributor

openshift-ci bot commented Jul 30, 2024

@droslean: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants