-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove cluster profile secrets from ci tools (& from prowgen
)
#4261
base: master
Are you sure you want to change the base?
Conversation
/cc @droslean |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: psalajova The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
12bca65
to
98f0c74
Compare
98f0c74
to
a75767e
Compare
@psalajova: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
prowgen
)prowgen
)
/test e2e |
This PR completely removes the cluster profiles' dependency on the Secret() function in code.
prowgen
will no longer generate the cluster profile volume and volume mount fields to prow jobs, meaning, if a test in a test config had a cluster profile defined, e.g.:The generated prow job in release/ci-operator/jobs will have the
secret-dir
arg option, volume and volume mount fields removed.Before:
After:
Merging of this PR will probably need to be synced with #4112 .