-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
manifests: reorganize to match infra operator convention #186
Conversation
17a0a88
to
7006d52
Compare
gah, forgot to update the |
7006d52
to
079cf4c
Compare
ok, turns out the |
079cf4c
to
86ae6ed
Compare
/retest |
/test e2e-aws |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgoodwin, sjenning The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
master is frozen but this is approved. will carry this commit in the base of ongoing PRs. next is #185 |
Most of this is a noop. Just reorganizing to look like other operators. Currently a ton of resources are just crammed into the
05_deployment.yaml
file.Examples:
https://github.com/openshift/cluster-ingress-operator/tree/master/manifests
https://github.com/openshift/console-operator/tree/master/manifests
The three actual changes are
default
SA with its bindings. New installs won't have this.Removal of(manifests: reorganize to match infra operator convention #186 (comment))control-plane: controller-manager
andcontroller-tools.k8s.io: "1.0"
labels@dgoodwin @joelddiaz @derekwaynecarr