Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No-Jira: Add multiarch reviewers and approvers to OWNER file #70

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

Karthik-K-N
Copy link
Member

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 2, 2024
@openshift-ci-robot
Copy link

@Karthik-K-N: This pull request explicitly references no jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from JoelSpeed and mkumatag July 2, 2024 04:44
@openshift-ci openshift-ci bot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jul 2, 2024
@Karthik-K-N
Copy link
Member Author

/verify-owners

@JoelSpeed
Copy link

I think you need to define an OWNERS_ALIASES file to be able to use groups like this

@Karthik-K-N
Copy link
Member Author

OWNERS_ALIASES

@JoelSpeed , @jaypoulz may I know where Do I need to define this.

@mkumatag
Copy link
Member

OWNERS_ALIASES

@JoelSpeed , @jaypoulz may I know where Do I need to define this.

something like this - https://github.com/openshift/release/blob/8745d27d5bde091ed1ff3521aa38d32c42b4599d/OWNERS_ALIASES#L339

@Karthik-K-N
Copy link
Member Author

OWNERS_ALIASES

@JoelSpeed , @jaypoulz may I know where Do I need to define this.

something like this - https://github.com/openshift/release/blob/8745d27d5bde091ed1ff3521aa38d32c42b4599d/OWNERS_ALIASES#L339

thanks, I thought it should be configured somewhere else also and used here.

@openshift-ci openshift-ci bot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jul 16, 2024
Copy link
Contributor

openshift-ci bot commented Jul 16, 2024

@Karthik-K-N: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@JoelSpeed
Copy link

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2024
Copy link
Contributor

openshift-ci bot commented Jul 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit cd903a7 into openshift:main Jul 22, 2024
6 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-powervs-cloud-controller-manager
This PR has been included in build ose-powervs-cloud-controller-manager-container-v4.17.0-202407221718.p0.gcd903a7.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants