Add possibility to configure the desired size of the instance volume

[cynepco3hahue]

It possible the situation when 16Gb is not enough, to run all needed workloads,
in this situatution the node will have DiskPressure condition and will start
to evict pods from it. We want to prevent such situations and make instance volume
size configurable.

[zeenix]

@cynepco3hahue Wouldn't this also require changes in Installer?

[cynepco3hahue]

@zeenix It will only affect workers, for masters I hardcoded size value under the terraform main.tf file,

--- a/data/data/libvirt/main.tf
+++ b/data/data/libvirt/main.tf
@@ -23,6 +23,7 @@ resource "libvirt_volume" "master" {
   count          = "${var.master_count}"
   name           = "${var.cluster_id}-master-${count.index}"
   base_volume_id = "${module.volume.coreos_base_volume_id}"
+  size           = 32212254720
 }

I think if installer guys will not be versus it, I can create the installer PR as well, to be honest it is interesting what the default value for volume size under the AWS.

[zeenix]

I think if installer guys will not be versus it, I can create the installer PR as well, to be honest it is interesting what the default valud for volume size under the AWS.

openshift/installer#2111 (comment)

[cynepco3hahue]

@zeenix Can we merge it?

[cynepco3hahue]

I do not sure that ci/prow/actuator-pkg-staleness still relevant after moving to go mod, at least I do not see this job anymore under machine-api-operator.

[zeenix]

@cynepco3hahue What i was saying was that currently the cpu and ram comes from the Installer through its manifest for worker nodes and you're adding new API to be able to specify volume size too so I'm a bit puzzled as to how this won't require changes in Installer?

[cynepco3hahue]

@zeenix Ah, now it more clear:) yes you right it will need changes under the installer as well, but as temp solution, you can generate manifests and sed new disk size under the machine set.

[cynepco3hahue]

I will create the installer PR on my free time:)

[zeenix]

/lgtm
/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zeenix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [zeenix]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-ci-robot]

@cynepco3hahue: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/actuator-pkg-staleness	32539e7	link	/test actuator-pkg-staleness

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.