Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1694819: bump deps and add nullable fields to crd validation #97

Merged
merged 6 commits into from
Apr 13, 2019
Merged

Bug 1694819: bump deps and add nullable fields to crd validation #97

merged 6 commits into from
Apr 13, 2019

Conversation

sallyom
Copy link
Contributor

@sallyom sallyom commented Mar 20, 2019 •
edited
Loading

  • bump to kubernetes-1.13.4
  • vendor openshift/kubernetes-apiextensions-apiserver to bring in PR that adds ability for nullable fields to CRDs, until that change merges upstream
  • update authentication crd with proper validation
  • bump deps, but keep patch on vendor until openshift/api types_oauth.go change is complete, so beta3-beta3 upgrades don't break.
  • fix build with bump-update clusterOperatorStatusController
  • switch glog to klog for kubernetes-1.13.4

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 20, 2019
@sallyom sallyom mentioned this pull request Mar 20, 2019
Merged
@sallyom
Copy link
Contributor Author

sallyom commented Mar 21, 2019

/test e2e-aws

@sallyom sallyom force-pushed the bump-deps branch 2 times, most recently from d076b5f to 06c3317 Compare March 25, 2019 20:01
@sallyom
Copy link
Contributor Author

sallyom commented Mar 26, 2019

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 26, 2019
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 29, 2019
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 29, 2019
@sallyom sallyom changed the title Bump deps Bump deps, Add crd-schema-gen tool Mar 30, 2019
@ericavonb
Copy link
Contributor

/retest

@sallyom sallyom force-pushed the bump-deps branch 3 times, most recently from 09c7bba to aae92eb Compare April 5, 2019 20:12
@sallyom sallyom changed the title Bump deps, Add crd-schema-gen tool Bump deps Apr 5, 2019
@sallyom sallyom force-pushed the bump-deps branch 3 times, most recently from af8f172 to aa3696e Compare April 6, 2019 12:10
@sallyom
Copy link
Contributor Author

sallyom commented Apr 6, 2019 •
edited
Loading

@enj only have to pin library-goupdated to master, and it's passing now : ) AFAICT this release from try.openshift.com has does not have the update we need: payload version 4.0.0-0.9 (beta3) https://openshift-release.svc.ci.openshift.org/releasestream/4.0/release/4.0.0-0.9, and here's openshift/api from last bump of openshift-apiserver(Mar25): https://github.com/openshift/cluster-openshift-apiserver-operator/blob/e1cc853a13df9389e55d67e0c26ad2b4403fd030/vendor/github.com/openshift/api/config/v1/types_oauth.go#L518-#L525

The update in openshift-apiserver-operator doesn't show up until 4.0.0-11

@sallyom sallyom changed the title Bump deps Bug 1694819: bump deps and add nullable fields to crd validation Apr 7, 2019
stlaz
stlaz reviewed Apr 8, 2019
View reviewed changes
pkg/crd-schema-gen.go Outdated Show resolved Hide resolved
glide.yaml Outdated Show resolved Hide resolved
glide.yaml Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 8, 2019
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 8, 2019
@sallyom sallyom force-pushed the bump-deps branch 2 times, most recently from 4344951 to 2fd4ac4 Compare April 10, 2019 18:26
@enj
Copy link
Contributor

enj commented Apr 11, 2019 •
edited
Loading

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2019
@enj
Copy link
Contributor

enj commented Apr 11, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 11, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2019
@sallyom
Copy link
Contributor Author

sallyom commented Apr 11, 2019

/test e2e-aws

1 similar comment
@sallyom
Copy link
Contributor Author

sallyom commented Apr 12, 2019

/test e2e-aws

@nee1esh
Copy link

nee1esh commented Apr 12, 2019

/retest

@sallyom
Copy link
Contributor Author

sallyom commented Apr 12, 2019

/test e2e-aws

sallyom added 6 commits April 12, 2019 17:37
@sallyom
fix build with bump
09e8d1d
@sallyom
update glide, pin kubernetes-apiextensions
c91dd5b
@sallyom
update crd validation nullable fields
1f0b039 
This brings in the nullable tags on fields, to resolve https://bugzilla.redhat.com/show_bug.cgi?id=1694819
@sallyom
glog to klog for kubernetes-1.13
7c895d5
@sallyom
bump(*)
cfe6080
@sallyom
Patch vendor/Add issuer to OpenIDIdentityProvider
680d259 
A recent change added an issuer field which can be used to perform
discovery via the /.well-known/openid-configuration endpoint.  This
makes the OpenIDURLs struct obsolete.  It will be removed when this
change in openshift/api is effective in all builds.
@sallyom
Copy link
Contributor Author

sallyom commented Apr 12, 2019

/test e2e-aws

@sallyom
Copy link
Contributor Author

sallyom commented Apr 13, 2019

@enj it's green 👀

@enj
Copy link
Contributor

enj commented Apr 13, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 13, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enj, sallyom, stlaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 96643e4 into openshift:master Apr 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stlaz stlaz stlaz left review comments

@sttts sttts sttts left review comments

@damemi damemi damemi left review comments

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

@bparees bparees Awaiting requested review from bparees

Assignees

@stlaz stlaz

@enj enj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@sallyom @ericavonb @stlaz @enj @openshift-bot @nee1esh @openshift-ci-robot @sttts @damemi @openshift-merge-robot