OCPBUGS-33493: Enable leader election for baremetal-operator

[honza]

• Depends on 🌱 Add more ctrl options flags metal3-io/baremetal-operator#1725

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: honza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [honza]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[zaneb]

We need to make sure that the timeouts are all configured in BMO according to OpenShift standards (see e.g. #403) before we merge this. Is that in progress also?

[honza]

Is that in progress also?

I just opened an upstream PR to add more ctlr.Options knobs. The present PR has been updated to make use of the new knobs in anticipation.

[openshift-ci]

@honza: This PR was included in a payload test run from openshift/installer#8391
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8ae1e8f0-0ee7-11ef-85b5-afc0d3b37ecf-0

[openshift-ci]

@zaneb: This PR was included in a payload test run from openshift/installer#8391
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-ovn-dualstack

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/33ac1c00-10e4-11ef-94cf-e0cf4724be59-0

[openshift-ci]

@honza: This PR was included in a payload test run from openshift/installer#8391
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/04558e70-114b-11ef-8515-2f8e3f8fdf31-0

[honza]

/retest-required

[zaneb]

I wouldn't have expected tests to pass before openshift/baremetal-operator#354 merged, but hopefully they should now.
/lgtm
/retest

[zaneb]

/label acknowledge-critical-fixes-only

[zaneb]

/retitle OCPBUGS-33493: Enable leader election for baremetal-operator

[openshift-ci-robot]

@honza: This pull request references Jira Issue OCPBUGS-33493, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mhanss

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

• Depends on 🌱 Add more ctrl options flags metal3-io/baremetal-operator#1725

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[honza]

I wouldn't have expected tests to pass before openshift/baremetal-operator#354 merged, but hopefully they should now.

I think I hit the retest 10 mins after it merged. Do we usually need to wait longer?

[zaneb]

I wouldn't have expected tests to pass before openshift/baremetal-operator#354 merged, but hopefully they should now.

I think I hit the retest 10 mins after it merged. Do we usually need to wait longer?

Sorry, I was looking at the wrong timestamp (the one from the ART bot saying it was in a build downstream).

It does take a while for the post-merge jobs to run and promote the new image into the CI repo. As far as I know there's nowhere you can easily tell when exactly that happens. I have definitely seen it fail to pick stuff up after 10mins.

[zaneb]

must-gather confirms that the previous test failures were due to the image not propagating yet:

2024-05-15T14:21:09.594617617Z flag provided but not defined: -lease-duration-seconds
2024-05-15T14:21:09.594617617Z Usage of /baremetal-operator:
2024-05-15T14:21:09.594617617Z   -build-preprov-image
2024-05-15T14:21:09.594617617Z     	enable integration with the PreprovisioningImage API
2024-05-15T14:21:09.594617617Z   -controller-concurrency int
2024-05-15T14:21:09.594617617Z     	Number of CRs of each type to process simultaneously
2024-05-15T14:21:09.594617617Z   -demo-mode
2024-05-15T14:21:09.594617617Z     	use the demo provisioner to set host states
2024-05-15T14:21:09.594617617Z   -dev
2024-05-15T14:21:09.594617617Z     	enable developer logging
2024-05-15T14:21:09.594617617Z   -enable-leader-election
2024-05-15T14:21:09.594617617Z     	Enable leader election for controller manager. Enabling this will ensure there is only one active controller manager.
2024-05-15T14:21:09.594617617Z   -health-addr string
2024-05-15T14:21:09.594617617Z     	The address the health endpoint binds to. (default ":9440")
2024-05-15T14:21:09.594741037Z   -kube-api-burst int
2024-05-15T14:21:09.594741037Z     	Maximum number of queries that should be allowed in one burst from the controller client to the Kubernetes API server. Default 30 (default 30)
2024-05-15T14:21:09.594741037Z   -kube-api-qps float
2024-05-15T14:21:09.594741037Z     	Maximum queries per second from the controller client to the Kubernetes API server. Default 20 (default 20)
2024-05-15T14:21:09.594741037Z   -kubeconfig string
2024-05-15T14:21:09.594741037Z     	Paths to a kubeconfig. Only required if out-of-cluster.
2024-05-15T14:21:09.594741037Z   -metrics-addr string
2024-05-15T14:21:09.594741037Z     	The address the metric endpoint binds to. (default "127.0.0.1:8085")
2024-05-15T14:21:09.594741037Z   -namespace string
2024-05-15T14:21:09.594741037Z     	Namespace that the controller watches to reconcile host resources. (default "openshift-machine-api")
2024-05-15T14:21:09.594741037Z   -test-mode
2024-05-15T14:21:09.594741037Z     	disable ironic communication
2024-05-15T14:21:09.594741037Z   -tls-cipher-suites string
2024-05-15T14:21:09.594741037Z     	Comma-separated list of cipher suites for the webhook server. If omitted, the default Go cipher suites will be used. 
2024-05-15T14:21:09.594741037Z     	Preferred values: TLS_AES_128_GCM_SHA256, TLS_AES_256_GCM_SHA384, TLS_CHACHA20_POLY1305_SHA256, TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA, TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256, TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA, TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384, TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305, TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256, TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA, TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256, TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA, TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384, TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305, TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256, TLS_RSA_WITH_AES_128_CBC_SHA, TLS_RSA_WITH_AES_128_GCM_SHA256, TLS_RSA_WITH_AES_256_CBC_SHA, TLS_RSA_WITH_AES_256_GCM_SHA384. 
2024-05-15T14:21:09.594741037Z     	Insecure values: TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA256, TLS_ECDHE_ECDSA_WITH_RC4_128_SHA, TLS_ECDHE_RSA_WITH_3DES_EDE_CBC_SHA, TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256, TLS_ECDHE_RSA_WITH_RC4_128_SHA, TLS_RSA_WITH_3DES_EDE_CBC_SHA, TLS_RSA_WITH_AES_128_CBC_SHA256, TLS_RSA_WITH_RC4_128_SHA.
2024-05-15T14:21:09.594741037Z   -tls-max-version string
2024-05-15T14:21:09.594741037Z     	The maximum TLS version in use by the webhook server.
2024-05-15T14:21:09.594741037Z     	Possible values are TLS12, TLS13. (default "TLS13")
2024-05-15T14:21:09.594741037Z   -tls-min-version string
2024-05-15T14:21:09.594741037Z     	The minimum TLS version in use by the webhook server.
2024-05-15T14:21:09.594741037Z     	Possible values are TLS12, TLS13. (default "TLS12")
2024-05-15T14:21:09.594741037Z   -webhook-port int
2024-05-15T14:21:09.594741037Z     	Webhook Server port (set to 0 to disable) (default 9443)

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 4a57b9c and 2 for PR HEAD 9dc040d in total

[openshift-ci]

@honza: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-metal-ipi-upgrade-ovn-ipv6	9dc040d	link	false	/test e2e-metal-ipi-upgrade-ovn-ipv6
ci/prow/e2e-metal-sdn-assisted	9dc040d	link	false	/test e2e-metal-sdn-assisted

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@honza: Jira Issue OCPBUGS-33493: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

• openshift/installer#8389 is open

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-33493 has not been moved to the MODIFIED state.

In response to this:

• Depends on 🌱 Add more ctrl options flags metal3-io/baremetal-operator#1725

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cluster-baremetal-operator-container-v4.17.0-202405171013.p0.g9842cb2.assembly.stream.el9 for distgit ose-cluster-baremetal-operator.
All builds following this will include this PR.